starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17312] [MERGED] Fixes: #17310 - Properly restrict GraphQL related object queries #15059

New Issue
Closed
opened 2025-12-30 00:19:42 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:42 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17312
Author: @DanSheps
Created: 8/30/2024
Status: ✅ Merged
Merged: 8/30/2024
Merged by: @jeremystretch

Base: develop ← Head: 17310-fix-graphql-related-objects-restriction

📝 Commits (3)

📊 Changes

10 files changed (+53 additions, -2 deletions)

View changed files

📝 netbox/circuits/tests/test_api.py (+4 -0)
📝 netbox/core/tests/test_api.py (+1 -0)
📝 netbox/dcim/tests/test_api.py (+27 -0)
📝 netbox/ipam/tests/test_api.py (+1 -0)
📝 netbox/netbox/graphql/schema.py (+1 -1)
📝 netbox/netbox/tests/test_graphql.py (+12 -1)
📝 netbox/tenancy/tests/test_api.py (+1 -0)
📝 netbox/virtualization/tests/test_api.py (+2 -0)
📝 netbox/vpn/tests/test_api.py (+3 -0)
📝 netbox/wireless/tests/test_api.py (+1 -0)

📄 Description

Fixes: #17310

  • Properly restrict GraphQL related object queries
  • Update tests to handle additional permission requirements

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17312 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 8/30/2024 **Status:** ✅ Merged **Merged:** 8/30/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17310-fix-graphql-related-objects-restriction` --- ### 📝 Commits (3) - [`950e291`](https://github.com/netbox-community/netbox/commit/950e2916ae49af439476926dd891cd3050657791) Fixes: #17310 - Fix GraphQL restriction of related objects - [`83743c6`](https://github.com/netbox-community/netbox/commit/83743c6a9750a5d46fa6eefe1868b492be7af376) Fix some failing tests - [`a11305e`](https://github.com/netbox-community/netbox/commit/a11305e3782772588e141f2e1146cf917bf82cf0) Fix test ### 📊 Changes **10 files changed** (+53 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/tests/test_api.py` (+4 -0) 📝 `netbox/core/tests/test_api.py` (+1 -0) 📝 `netbox/dcim/tests/test_api.py` (+27 -0) 📝 `netbox/ipam/tests/test_api.py` (+1 -0) 📝 `netbox/netbox/graphql/schema.py` (+1 -1) 📝 `netbox/netbox/tests/test_graphql.py` (+12 -1) 📝 `netbox/tenancy/tests/test_api.py` (+1 -0) 📝 `netbox/virtualization/tests/test_api.py` (+2 -0) 📝 `netbox/vpn/tests/test_api.py` (+3 -0) 📝 `netbox/wireless/tests/test_api.py` (+1 -0) </details> ### 📄 Description ### Fixes: #17310 * Properly restrict GraphQL related object queries * Update tests to handle additional permission requirements --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:42 +01:00
adam closed this issue 2025-12-30 00:19:42 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15059
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?