starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17299] [MERGED] 17289 enforce minimum password strength #15051

New Issue
Closed
opened 2025-12-30 00:19:40 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:40 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17299
Author: @arthanson
Created: 8/29/2024
Status: ✅ Merged
Merged: 8/30/2024
Merged by: @jeremystretch

Base: feature ← Head: 17289-password-strength

📝 Commits (10+)

  • 30822ee 17289 add password validation
  • 85229fa 17289 add password validation
  • d6f4775 17289 fix tests
  • d0b2f0c 17289 fix tests
  • 37b724c Update netbox/utilities/password_validation.py
  • 329f7c3 Update netbox/utilities/password_validation.py
  • b57de25 Update netbox/utilities/password_validation.py
  • 44c37ec 17289 update tests
  • 4b5dad8 17289 remove common password check
  • 372bcba 17289 fix user create

📊 Changes

4 files changed (+94 additions, -22 deletions)

View changed files

📝 netbox/netbox/settings.py (+11 -2)
📝 netbox/users/tests/test_api.py (+30 -10)
📝 netbox/users/tests/test_views.py (+26 -10)
➕ netbox/utilities/password_validation.py (+27 -0)

📄 Description

Fixes: #17289

Enforce default minimum password strength:

  • 12 characters minimum
  • similarities to user attributes (first name, last name, email)
  • common password check
  • must contain one number, one upper-case letter and one lower-case letter.

Change Password | NetBox 2024-08-29 08-58-46

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17299 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 8/29/2024 **Status:** ✅ Merged **Merged:** 8/30/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `17289-password-strength` --- ### 📝 Commits (10+) - [`30822ee`](https://github.com/netbox-community/netbox/commit/30822ee7d1d36cafc04996c7971bf4b869b7ca11) 17289 add password validation - [`85229fa`](https://github.com/netbox-community/netbox/commit/85229faad0029a3770ca3b31036856e0b3bbe49b) 17289 add password validation - [`d6f4775`](https://github.com/netbox-community/netbox/commit/d6f477599dd1a2304a1dc4bbed852f9621fada12) 17289 fix tests - [`d0b2f0c`](https://github.com/netbox-community/netbox/commit/d0b2f0c5a160f5fcd21c69d2e653c2acd62a116b) 17289 fix tests - [`37b724c`](https://github.com/netbox-community/netbox/commit/37b724c6bc3c94aed4a69d9aa19fd8438e724eb0) Update netbox/utilities/password_validation.py - [`329f7c3`](https://github.com/netbox-community/netbox/commit/329f7c32950eb64a2c76f24ba057f6669ec63fa1) Update netbox/utilities/password_validation.py - [`b57de25`](https://github.com/netbox-community/netbox/commit/b57de257b52756df5cedc8b87c906509cd7fcc83) Update netbox/utilities/password_validation.py - [`44c37ec`](https://github.com/netbox-community/netbox/commit/44c37ecdc522275ce6f75b002a3821e19d91fc53) 17289 update tests - [`4b5dad8`](https://github.com/netbox-community/netbox/commit/4b5dad85555381bb08c31a50997208dbd1047073) 17289 remove common password check - [`372bcba`](https://github.com/netbox-community/netbox/commit/372bcbacc776faf7b58212b8e2fd675894020786) 17289 fix user create ### 📊 Changes **4 files changed** (+94 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/settings.py` (+11 -2) 📝 `netbox/users/tests/test_api.py` (+30 -10) 📝 `netbox/users/tests/test_views.py` (+26 -10) ➕ `netbox/utilities/password_validation.py` (+27 -0) </details> ### 📄 Description ### Fixes: #17289 Enforce default minimum password strength: * 12 characters minimum * similarities to user attributes (first name, last name, email) * common password check * must contain one number, one upper-case letter and one lower-case letter. ![Change Password | NetBox 2024-08-29 08-58-46](https://github.com/user-attachments/assets/f027edd3-e521-45fc-96ff-01b8a90a026b) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:40 +01:00
adam closed this issue 2025-12-30 00:19:40 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15051
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?