starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17290] [MERGED] Fixes #16756: Fix table pagination for custom script results #15046

New Issue
Closed
opened 2025-12-30 00:19:38 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:38 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17290
Author: @jeremystretch
Created: 8/28/2024
Status: ✅ Merged
Merged: 8/28/2024
Merged by: @jeremystretch

Base: develop ← Head: 16756-fix-script-results-display

📝 Commits (1)

  • 96cd781 Fixes #16756: Fix table pagination for custom script results

📊 Changes

3 files changed (+8 additions, -9 deletions)

View changed files

📝 netbox/extras/views.py (+3 -0)
📝 netbox/templates/extras/htmx/script_result.html (+5 -1)
📝 netbox/templates/extras/script_result.html (+0 -8)

📄 Description

Fixes: #16756

Submitting this as an alternate to PR #17129.

  • Provide a hook in ScriptResultView to return only the rendered table
  • Load the log as an HTMX table (though not using the {% htmx_table %} tag due to a limitation concerning view name resolution)
  • Cleanup: Remove obsolete code from script_result.html

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17290 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 8/28/2024 **Status:** ✅ Merged **Merged:** 8/28/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16756-fix-script-results-display` --- ### 📝 Commits (1) - [`96cd781`](https://github.com/netbox-community/netbox/commit/96cd781816b50ad3131529533ca84e437d884ba1) Fixes #16756: Fix table pagination for custom script results ### 📊 Changes **3 files changed** (+8 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/views.py` (+3 -0) 📝 `netbox/templates/extras/htmx/script_result.html` (+5 -1) 📝 `netbox/templates/extras/script_result.html` (+0 -8) </details> ### 📄 Description ### Fixes: #16756 Submitting this as an alternate to PR #17129. - Provide a hook in `ScriptResultView` to return only the rendered table - Load the log as an HTMX table (though not using the `{% htmx_table %}` tag due to a limitation concerning view name resolution) - Cleanup: Remove obsolete code from `script_result.html` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:38 +01:00
adam closed this issue 2025-12-30 00:19:38 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15046
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?