starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17270] [MERGED] Closes #17256: Fix translation support in VLAN group scope assignment form #15041

New Issue
Closed
opened 2025-12-30 00:19:36 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:36 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17270
Author: @jeremystretch
Created: 8/26/2024
Status: ✅ Merged
Merged: 8/27/2024
Merged by: @jeremystretch

Base: develop ← Head: 17256-vlangroup-scope-selector

📝 Commits (4)

  • dc6fcf7 Closes #17256: Fix translation support in VLAN group scope assignment form
  • b7306ac Disable scope field if scope type not selected; update label on type change
  • 9d1afbe Reset selected scope object when changing scope type
  • e747ad5 Merge branch 'develop' into 17256-vlangroup-scope-selector

📊 Changes

5 files changed (+42 additions, -245 deletions)

View changed files

📝 netbox/ipam/forms/model_forms.py (+33 -82)
📝 netbox/project-static/dist/netbox.js (+5 -5)
📝 netbox/project-static/dist/netbox.js.map (+3 -3)
📝 netbox/project-static/src/forms/index.ts (+1 -2)
➖ netbox/project-static/src/forms/scopeSelector.ts (+0 -153)

📄 Description

Fixes: #17256

  • Convert VLANGroupForm to use a single dynamically-rendered scope field
  • Ditch an entire TypeScript module dedicated to displaying the old form 🎉

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17270 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 8/26/2024 **Status:** ✅ Merged **Merged:** 8/27/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17256-vlangroup-scope-selector` --- ### 📝 Commits (4) - [`dc6fcf7`](https://github.com/netbox-community/netbox/commit/dc6fcf7d10394dc37ea76342e505cc1ac1046abf) Closes #17256: Fix translation support in VLAN group scope assignment form - [`b7306ac`](https://github.com/netbox-community/netbox/commit/b7306ac11851b327ab782061450c46179e5bfcca) Disable scope field if scope type not selected; update label on type change - [`9d1afbe`](https://github.com/netbox-community/netbox/commit/9d1afbe33661a52c5e005ce9e3d8e7d204dee039) Reset selected scope object when changing scope type - [`e747ad5`](https://github.com/netbox-community/netbox/commit/e747ad5b51a067eb788cdc9f238da6c4ea0339d8) Merge branch 'develop' into 17256-vlangroup-scope-selector ### 📊 Changes **5 files changed** (+42 additions, -245 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/forms/model_forms.py` (+33 -82) 📝 `netbox/project-static/dist/netbox.js` (+5 -5) 📝 `netbox/project-static/dist/netbox.js.map` (+3 -3) 📝 `netbox/project-static/src/forms/index.ts` (+1 -2) ➖ `netbox/project-static/src/forms/scopeSelector.ts` (+0 -153) </details> ### 📄 Description ### Fixes: #17256 - Convert VLANGroupForm to use a single dynamically-rendered `scope` field - Ditch an entire TypeScript module dedicated to displaying the old form :tada: --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:36 +01:00
adam closed this issue 2025-12-30 00:19:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15041
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?