starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17248] [MERGED] 17186 change custom link button color from outline-dark to outline-se… #15040

New Issue
Closed
opened 2025-12-30 00:19:36 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:36 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17248
Author: @arthanson
Created: 8/22/2024
Status: ✅ Merged
Merged: 8/27/2024
Merged by: @jeremystretch

Base: develop ← Head: 17186-custom-link

📝 Commits (6)

  • 2dacdce 17186 change custom link button color from outline-dark to outline-secondary
  • 1d9dbae Merge branch 'develop' into 17186-custom-link
  • 90b4238 17186 change choice to default
  • 0f7b12f 17186 change choice to default
  • a98b6a6 17186 change choice to default
  • dec7ac7 Misc cleanup

📊 Changes

3 files changed (+29 additions, -5 deletions)

View changed files

➕ netbox/extras/migrations/0116_custom_link_button_color.py (+25 -0)
📝 netbox/extras/templatetags/custom_links.py (+3 -1)
📝 netbox/netbox/choices.py (+1 -4)

📄 Description

Fixes: #17186

The link button choices has default as outline-dark which it appends to btn- to get the button color. outline-dark will not show in dark mode, so as previous changes to other buttons change to outline-secondary. Migration was needed to change this is in the database as it uses the database char value to create the button class.

123 | NetBox 2024-08-22 12-47-15

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17248 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 8/22/2024 **Status:** ✅ Merged **Merged:** 8/27/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17186-custom-link` --- ### 📝 Commits (6) - [`2dacdce`](https://github.com/netbox-community/netbox/commit/2dacdcec278f4ad4bdda74097c0451e510a0892f) 17186 change custom link button color from outline-dark to outline-secondary - [`1d9dbae`](https://github.com/netbox-community/netbox/commit/1d9dbae1048d09de33f5b38c74b9c727ebf24f43) Merge branch 'develop' into 17186-custom-link - [`90b4238`](https://github.com/netbox-community/netbox/commit/90b423812c5d3a974fe8609a2f0d9d0536975f74) 17186 change choice to default - [`0f7b12f`](https://github.com/netbox-community/netbox/commit/0f7b12f93911f4b825b9b9106e6f996d34fc9838) 17186 change choice to default - [`a98b6a6`](https://github.com/netbox-community/netbox/commit/a98b6a6fdff33b88ff12af45e5b088de8955039b) 17186 change choice to default - [`dec7ac7`](https://github.com/netbox-community/netbox/commit/dec7ac79bfca50817b19a28ea0fe1a6cfdd3a1cd) Misc cleanup ### 📊 Changes **3 files changed** (+29 additions, -5 deletions) <details> <summary>View changed files</summary> ➕ `netbox/extras/migrations/0116_custom_link_button_color.py` (+25 -0) 📝 `netbox/extras/templatetags/custom_links.py` (+3 -1) 📝 `netbox/netbox/choices.py` (+1 -4) </details> ### 📄 Description ### Fixes: #17186 The link button choices has default as `outline-dark` which it appends to btn- to get the button color. outline-dark will not show in dark mode, so as previous changes to other buttons change to outline-secondary. Migration was needed to change this is in the database as it uses the database char value to create the button class. ![123 | NetBox 2024-08-22 12-47-15](https://github.com/user-attachments/assets/18db71f8-3e26-4d4f-ad0a-4d73a12361fa) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:36 +01:00
adam closed this issue 2025-12-30 00:19:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15040
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?