starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17246] [MERGED] 17117 change caret to html entity to fix safari performacne issue #15034

New Issue
Closed
opened 2025-12-30 00:19:34 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:34 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17246
Author: @arthanson
Created: 8/22/2024
Status: ✅ Merged
Merged: 8/26/2024
Merged by: @jeremystretch

Base: develop ← Head: 17117-safari

📝 Commits (8)

  • 6bae396 change caret to html entity to fix safari performacne issue
  • a00218d change caret to html entity to fix safari performacne issue
  • c47b92b 17117 use material icon
  • 5cf8a26 17117 use material icon
  • b3a31a1 17117 use material icon
  • cb8d759 17117 fix vertical align
  • ae0b372 Merge branch 'develop' into 17117-safari
  • d555413 Add comments & tweak padding

📊 Changes

2 files changed (+14 additions, -1 deletions)

View changed files

📝 netbox/project-static/dist/netbox.css (+1 -1)
📝 netbox/project-static/styles/overrides/_tabler.scss (+13 -0)

📄 Description

Fixes: #17117

Tabler was creating the caret for the sidebar and buttons via a border and then doing a transform rotation of 45-degrees. This was causing a performance issue on safari. Changed the css to get rid of the transform and use the material icon for the caret.

In screenshot left is old, right is new:

caret3

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17246 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 8/22/2024 **Status:** ✅ Merged **Merged:** 8/26/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17117-safari` --- ### 📝 Commits (8) - [`6bae396`](https://github.com/netbox-community/netbox/commit/6bae396f32aa02c381f5a7fa87bd494edb04d253) change caret to html entity to fix safari performacne issue - [`a00218d`](https://github.com/netbox-community/netbox/commit/a00218dff949790fa9f9062bdbbd53121e0ca124) change caret to html entity to fix safari performacne issue - [`c47b92b`](https://github.com/netbox-community/netbox/commit/c47b92bc45e8e508c03e042bac0a5a18169ef60a) 17117 use material icon - [`5cf8a26`](https://github.com/netbox-community/netbox/commit/5cf8a260d13a974ef2c28e830c963e848d5c4907) 17117 use material icon - [`b3a31a1`](https://github.com/netbox-community/netbox/commit/b3a31a14dbf4726dc318b74ddfbf5904b8d45c7d) 17117 use material icon - [`cb8d759`](https://github.com/netbox-community/netbox/commit/cb8d7598a5c372a0926b131cecd1080c62c84476) 17117 fix vertical align - [`ae0b372`](https://github.com/netbox-community/netbox/commit/ae0b372128ecf3ff26787d23932795527bc3349b) Merge branch 'develop' into 17117-safari - [`d555413`](https://github.com/netbox-community/netbox/commit/d555413254d6ebcf037b5ed8f7f5bac33e5a5347) Add comments & tweak padding ### 📊 Changes **2 files changed** (+14 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/project-static/dist/netbox.css` (+1 -1) 📝 `netbox/project-static/styles/overrides/_tabler.scss` (+13 -0) </details> ### 📄 Description ### Fixes: #17117 Tabler was creating the caret for the sidebar and buttons via a border and then doing a transform rotation of 45-degrees. This was causing a performance issue on safari. Changed the css to get rid of the transform and use the material icon for the caret. In screenshot left is old, right is new: ![caret3](https://github.com/user-attachments/assets/05138080-1e22-495a-93b1-5a9537f7020f) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:34 +01:00
adam closed this issue 2025-12-30 00:19:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15034
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?