starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17162] [MERGED] Fixes #17098: Prevent automatic deletion of related notifications when deleting an object #15011

New Issue
Closed
opened 2025-12-30 00:19:27 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:27 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17162
Author: @jeremystretch
Created: 8/14/2024
Status: ✅ Merged
Merged: 8/15/2024
Merged by: @jeremystretch

Base: feature ← Head: 17098-notifications-generic-relation

📝 Commits (1)

  • 6c359df Fixes #17098: Prevent automatic deletion of related notifications when deleting an object

📊 Changes

1 file changed (+0 additions, -5 deletions)

View changed files

📝 netbox/netbox/models/features.py (+0 -5)

📄 Description

Fixes: #17098

Remove the GenericRelation on NotificationsMixin to avoid automatically deleting any notifications referencing an object being deleted.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17162 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 8/14/2024 **Status:** ✅ Merged **Merged:** 8/15/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `17098-notifications-generic-relation` --- ### 📝 Commits (1) - [`6c359df`](https://github.com/netbox-community/netbox/commit/6c359df1695a74f51cbaa848703e9078b01f7816) Fixes #17098: Prevent automatic deletion of related notifications when deleting an object ### 📊 Changes **1 file changed** (+0 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/models/features.py` (+0 -5) </details> ### 📄 Description ### Fixes: #17098 Remove the GenericRelation on NotificationsMixin to avoid automatically deleting any notifications referencing an object being deleted. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:27 +01:00
adam closed this issue 2025-12-30 00:19:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15011
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?