starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17113] [CLOSED] 17096 Do not omit "False" values from the request URL for cloned fields #14998

New Issue
Closed
opened 2025-12-30 00:19:22 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:22 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17113
Author: @peteeckel
Created: 8/9/2024
Status: ❌ Closed

Base: develop ← Head: fix/17096-clone-boolean-fields

📝 Commits (3)

  • 3dea3ff Do not omit "False" values from the request URL for cloned fields
  • e8a5fa3 Limit the fix to custom field data
  • ce7343c Properly handle "False" as a text parameter when initialising NetBoxModelForm

📊 Changes

2 files changed (+11 additions, -1 deletions)

View changed files

📝 netbox/netbox/forms/base.py (+10 -0)
📝 netbox/utilities/querydict.py (+1 -1)

📄 Description

Fixes: #17096

The current implementation leaves the URL parameters for boolean fields empty if their value is actually False, which leads to fields with False values not being cloned correctly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17113 **Author:** [@peteeckel](https://github.com/peteeckel) **Created:** 8/9/2024 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `fix/17096-clone-boolean-fields` --- ### 📝 Commits (3) - [`3dea3ff`](https://github.com/netbox-community/netbox/commit/3dea3ffe050a2d261677dd3dc66e1ac0e32fb692) Do not omit "False" values from the request URL for cloned fields - [`e8a5fa3`](https://github.com/netbox-community/netbox/commit/e8a5fa32ce1709726c04e6f150f80b2a88bf0f38) Limit the fix to custom field data - [`ce7343c`](https://github.com/netbox-community/netbox/commit/ce7343c279b48e460d7e93cac71aa52a9a819257) Properly handle "False" as a text parameter when initialising NetBoxModelForm ### 📊 Changes **2 files changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/forms/base.py` (+10 -0) 📝 `netbox/utilities/querydict.py` (+1 -1) </details> ### 📄 Description ### Fixes: #17096 The current implementation leaves the URL parameters for boolean fields empty if their value is actually `False`, which leads to fields with `False` values not being cloned correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:22 +01:00
adam closed this issue 2025-12-30 00:19:22 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14998
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?