starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17078] [MERGED] 16670 fix OpenAPI schema generation with nested serializers #14995

New Issue
Closed
opened 2025-12-30 00:19:20 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:20 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17078
Author: @arthanson
Created: 8/5/2024
Status: ✅ Merged
Merged: 8/27/2024
Merged by: @jeremystretch

Base: develop ← Head: 16670-nested-serializer

📝 Commits (4)

  • 5fa0a7f 16670 fix OpenAPI schema generation with nested serializers
  • b614196 16670 fix comment
  • c992a2f Merge branch 'develop' into 16670-nested-serializer
  • a900cf8 Add comment; misc cleanup

📊 Changes

1 file changed (+10 additions, -3 deletions)

View changed files

📝 netbox/core/api/schema.py (+10 -3)

📄 Description

Fixes: #16670

Adds 'Brief' to serializer name if it is called with nested=True, Adding 'Nested' conflicts with existing Nested Serializers, so went with Brief.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17078 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 8/5/2024 **Status:** ✅ Merged **Merged:** 8/27/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16670-nested-serializer` --- ### 📝 Commits (4) - [`5fa0a7f`](https://github.com/netbox-community/netbox/commit/5fa0a7f1029064b897742344561aa2cdfa509ddd) 16670 fix OpenAPI schema generation with nested serializers - [`b614196`](https://github.com/netbox-community/netbox/commit/b614196ff84745879d4696f9ef82d26f1b1d5cc8) 16670 fix comment - [`c992a2f`](https://github.com/netbox-community/netbox/commit/c992a2f9464a3559eca5c77a61a71e35a0a742fa) Merge branch 'develop' into 16670-nested-serializer - [`a900cf8`](https://github.com/netbox-community/netbox/commit/a900cf8bfc2eca31db20f69cd2ea52e13289dc26) Add comment; misc cleanup ### 📊 Changes **1 file changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/api/schema.py` (+10 -3) </details> ### 📄 Description ### Fixes: #16670 Adds 'Brief' to serializer name if it is called with nested=True, Adding 'Nested' conflicts with existing Nested Serializers, so went with Brief. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:20 +01:00
adam closed this issue 2025-12-30 00:19:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14995
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?