[PR #17035] [MERGED] 17034 Add error handling to Plugins Catalog API #14983

New Issue

adam · 2025-12-30T00:19:16+01:00

adam commented

2025-12-30 00:19:16 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17035
Author: @arthanson
Created: 7/31/2024
Status: ✅ Merged
Merged: 8/1/2024
Merged by: @jeremystretch

Base: feature ← Head: 17034-plugins-catalog

📝 Commits (4)

f53ff24 17034 add error handling to plugins catalog API
0440e7e 17034 refactor from review feedback
65cd124 17034 refactor from review feedback
0902428 Misc cleanup

📊 Changes

2 files changed (+106 additions, -91 deletions)

View changed files

📝 netbox/core/plugins.py (+85 -83)
📝 netbox/core/views.py (+21 -8)

📄 Description

Fixes: #17034

Put error handling around plugins catalog API, added a toast if the API could not be loaded with a 15 minute timeout so you don't keep getting spammed by toasts. Not sure if this is acceptable for an offline installation as when you go back to the page (after 15 minutes) you will get another toast.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17035 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 7/31/2024 **Status:** ✅ Merged **Merged:** 8/1/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `17034-plugins-catalog` --- ### 📝 Commits (4) - [`f53ff24`](https://github.com/netbox-community/netbox/commit/f53ff24885940be53fa06fd021f2e2892fab57a9) 17034 add error handling to plugins catalog API - [`0440e7e`](https://github.com/netbox-community/netbox/commit/0440e7e7b9fadb82c7fe54c2e499940da5d7dc86) 17034 refactor from review feedback - [`65cd124`](https://github.com/netbox-community/netbox/commit/65cd124f6ff809af1f762453dcf18028cb0fc13d) 17034 refactor from review feedback - [`0902428`](https://github.com/netbox-community/netbox/commit/09024283b89ba52ae9cdfcab44fde81c4736c770) Misc cleanup ### 📊 Changes **2 files changed** (+106 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/plugins.py` (+85 -83) 📝 `netbox/core/views.py` (+21 -8) </details> ### 📄 Description ### Fixes: #17034 Put error handling around plugins catalog API, added a toast if the API could not be loaded with a 15 minute timeout so you don't keep getting spammed by toasts. Not sure if this is acceptable for an offline installation as when you go back to the page (after 15 minutes) you will get another toast. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:19:16 +01:00

adam closed this issue

2025-12-30 00:19:17 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#14983