[PR #17015] [MERGED] 16946 return empty queryset if filterset is not valid #14977

New Issue

adam · 2025-12-30T00:19:14+01:00

adam commented

2025-12-30 00:19:14 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17015
Author: @arthanson
Created: 7/29/2024
Status: ✅ Merged
Merged: 8/27/2024
Merged by: @jeremystretch

Base: develop ← Head: 16946-graphql-filter-error

📝 Commits (7)

55ff836 16946 raise error if filterset is not valid
d8de18b 16946 cleanup
28eba4b Merge branch 'develop' into 16946-graphql-filter-error
4af490a Merge branch 'develop' into 16946-graphql-filter-error
0180a35 16946 change to None qs return and add test
39ac70b Remove obsolete logic
ee030f8 Clean up test case

📊 Changes

2 files changed (+56 additions, -3 deletions)

View changed files

📝 netbox/netbox/graphql/filter_mixins.py (+7 -2)
📝 netbox/netbox/tests/test_graphql.py (+49 -1)

📄 Description

Fixes: #16946

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17015 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 7/29/2024 **Status:** ✅ Merged **Merged:** 8/27/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16946-graphql-filter-error` --- ### 📝 Commits (7) - [`55ff836`](https://github.com/netbox-community/netbox/commit/55ff836db771cffa87d4ce6d78bf34dc5fd73300) 16946 raise error if filterset is not valid - [`d8de18b`](https://github.com/netbox-community/netbox/commit/d8de18b9bf51e354ae29f8aff8a7e702d2ef473e) 16946 cleanup - [`28eba4b`](https://github.com/netbox-community/netbox/commit/28eba4bccefdefe357f134ad762cab8cbb14170f) Merge branch 'develop' into 16946-graphql-filter-error - [`4af490a`](https://github.com/netbox-community/netbox/commit/4af490af6b0d39ca3bd80de36c334f7661de4468) Merge branch 'develop' into 16946-graphql-filter-error - [`0180a35`](https://github.com/netbox-community/netbox/commit/0180a3546d2c874153dbda471760c3e997026f42) 16946 change to None qs return and add test - [`39ac70b`](https://github.com/netbox-community/netbox/commit/39ac70b03653a433a3143669c9405d07e13e51ac) Remove obsolete logic - [`ee030f8`](https://github.com/netbox-community/netbox/commit/ee030f8c1decbbc75f4d93f983eab61bd4f0d27c) Clean up test case ### 📊 Changes **2 files changed** (+56 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/graphql/filter_mixins.py` (+7 -2) 📝 `netbox/netbox/tests/test_graphql.py` (+49 -1) </details> ### 📄 Description ### Fixes: #16946 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:19:14 +01:00

adam closed this issue

2025-12-30 00:19:14 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#14977