[PR #16990] [MERGED] Fixes #16964: Ensure configured password validators are enforced #14971

New Issue

adam · 2025-12-30T00:19:13+01:00

adam commented

2025-12-30 00:19:13 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16990
Author: @jeremystretch
Created: 7/26/2024
Status: ✅ Merged
Merged: 7/26/2024
Merged by: @jeremystretch

Base: develop ← Head: 16964-validate-password-when-creating-updating-user-password

📝 Commits (2)

d3a9183 Closes #16964: Validate password when creating a new user or updating password for an existing user
968770b Add serializer validation & tests

📊 Changes

4 files changed (+71 additions, -3 deletions)

View changed files

📝 netbox/users/api/serializers_/users.py (+9 -1)
📝 netbox/users/forms/model_forms.py (+5 -1)
📝 netbox/users/tests/test_api.py (+26 -0)
📝 netbox/users/tests/test_views.py (+31 -1)

📄 Description

Fixes: #16964

Extend @nishant131's initial work from PR #16982
Add validation logic on REST serializer for User model
Add view & API tests

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16990 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 7/26/2024 **Status:** ✅ Merged **Merged:** 7/26/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16964-validate-password-when-creating-updating-user-password` --- ### 📝 Commits (2) - [`d3a9183`](https://github.com/netbox-community/netbox/commit/d3a918357cfa1289c8b1f6c27bb88b937d44d9e1) Closes #16964: Validate password when creating a new user or updating password for an existing user - [`968770b`](https://github.com/netbox-community/netbox/commit/968770b8250f69958231ecdfd0604072242fb4d6) Add serializer validation & tests ### 📊 Changes **4 files changed** (+71 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/users/api/serializers_/users.py` (+9 -1) 📝 `netbox/users/forms/model_forms.py` (+5 -1) 📝 `netbox/users/tests/test_api.py` (+26 -0) 📝 `netbox/users/tests/test_views.py` (+31 -1) </details> ### 📄 Description ### Fixes: #16964 - Extend @nishant131's initial work from PR #16982 - Add validation logic on REST serializer for User model - Add view & API tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:19:13 +01:00

adam closed this issue

2025-12-30 00:19:13 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#14971