starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16948] [CLOSED] 16392 collapse side navigation #14959

New Issue
Closed
opened 2025-12-30 00:19:08 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:08 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16948
Author: @andrewgormley
Created: 7/19/2024
Status: ❌ Closed

Base: feature-ui ← Head: 16392-collapse-side-navigation

📝 Commits (4)

📊 Changes

6 files changed (+113 additions, -33 deletions)

View changed files

📝 netbox/project-static/dist/netbox.css (+1 -1)
📝 netbox/project-static/dist/netbox.js (+6 -6)
📝 netbox/project-static/dist/netbox.js.map (+1 -1)
📝 netbox/project-static/src/sidenav.ts (+2 -3)
📝 netbox/project-static/styles/transitional/_navigation.scss (+86 -18)
📝 netbox/templates/base/layout.html (+17 -4)

📄 Description

Fixes: #16392

  1. Created toggle button
  2. Utilised existing script to implement 'pin' and 'hover' behaviour to side navigation
  3. Moved logo to top bar
  4. Top bar now sits on top of side navigation
  5. Increased width of search input
  6. Added padding to bottom of navigation to ensure links are not covered by native browser link hover state

Outstanding issues:

  • Issue - when sub menu != current page then the sub menu does not collapse, Ideally we want to mirror the behaviour of the active sub menu.
  • Issue - You need to click the toggle button twice to activate
  • Issue - Active state is only applied to collapsed menu item after a user has hovered on the side nav, ideally this is implemented on page load.
  • Issue - Tabbing through menu items does not expand the side navigation
  • Issue - Changing the side nav from un-pinned to pinned does not update the state of the active nav item if there is one available.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16948 **Author:** [@andrewgormley](https://github.com/andrewgormley) **Created:** 7/19/2024 **Status:** ❌ Closed **Base:** `feature-ui` ← **Head:** `16392-collapse-side-navigation` --- ### 📝 Commits (4) - [`ab9ec96`](https://github.com/netbox-community/netbox/commit/ab9ec9644ec519258d8318dd2d62c0d66af46d1b) edited navigation layout - [`e243e2a`](https://github.com/netbox-community/netbox/commit/e243e2ad1b9912778619f8ad9ce770af90b63f1f) added bottom padding to side nav - [`50535b4`](https://github.com/netbox-community/netbox/commit/50535b4f97908bdbe78eda68c0f0b9b83beca420) added comments - [`2bd044a`](https://github.com/netbox-community/netbox/commit/2bd044a600908f9c964302cc952eeb212f7c36e3) styling fixes ### 📊 Changes **6 files changed** (+113 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `netbox/project-static/dist/netbox.css` (+1 -1) 📝 `netbox/project-static/dist/netbox.js` (+6 -6) 📝 `netbox/project-static/dist/netbox.js.map` (+1 -1) 📝 `netbox/project-static/src/sidenav.ts` (+2 -3) 📝 `netbox/project-static/styles/transitional/_navigation.scss` (+86 -18) 📝 `netbox/templates/base/layout.html` (+17 -4) </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be approved and assigned prior to opening a pull request. This helps avoid waste time and effort on a proposed change that we might not be able to accept. IF YOUR PULL REQUEST DOES NOT REFERENCE AN ISSUE WHICH HAS BEEN ASSIGNED TO YOU, IT WILL BE CLOSED AUTOMATICALLY. Please specify your assigned issue number on the line below. --> ### Fixes: #16392 <!-- Please include a summary of the proposed changes below. --> 1. Created toggle button 2. Utilised existing script to implement 'pin' and 'hover' behaviour to side navigation 3. Moved logo to top bar 4. Top bar now sits on top of side navigation 5. Increased width of search input 6. Added padding to bottom of navigation to ensure links are not covered by native browser link hover state Outstanding issues: - [ ] Issue - when sub menu != current page then the sub menu does not collapse, Ideally we want to mirror the behaviour of the active sub menu. - [ ] Issue - You need to click the toggle button twice to activate - [ ] Issue - Active state is only applied to collapsed menu item after a user has hovered on the side nav, ideally this is implemented on page load. - [ ] Issue - Tabbing through menu items does not expand the side navigation - [ ] Issue - Changing the side nav from un-pinned to pinned does not update the state of the active nav item if there is one available. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:08 +01:00
adam closed this issue 2025-12-30 00:19:08 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14959
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?