starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16947] [CLOSED] Escape config-revision banner values by default Fixes #16934 #14956

New Issue
Closed
opened 2025-12-30 00:19:07 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:07 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16947
Author: @jeffgdotorg
Created: 7/19/2024
Status: ❌ Closed

Base: develop ← Head: jeffg/16934-escape-banners

📝 Commits (3)

  • 7ab0345 Issue #16934: Escape config-revision banner values by default
  • c85625b Issue #16934: Escape config-revision banner values by default
  • 56739d2 Corrected info in docs/configuration/security.md to reflect that ESCAPE_BANNERS is new in v4.0.8

📊 Changes

7 files changed (+41 additions, -6 deletions)

View changed files

📝 docs/configuration/security.md (+11 -0)
📝 netbox/core/forms/model_forms.py (+5 -1)
📝 netbox/netbox/configuration_example.py (+3 -0)
📝 netbox/netbox/settings.py (+1 -0)
📝 netbox/templates/base/layout.html (+15 -3)
📝 netbox/templates/login.html (+5 -1)
📝 netbox/utilities/error_handlers.py (+1 -1)

📄 Description

Fixes: #16934

Escape config-revision banner values by default Fixes #16934

  • Default to HTML-escaping banner values before displaying them
  • Also default to escaping banner values in config form previews
  • Escape names of dependent objects displayed when deleting parents
  • Update configuration docs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16947 **Author:** [@jeffgdotorg](https://github.com/jeffgdotorg) **Created:** 7/19/2024 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `jeffg/16934-escape-banners` --- ### 📝 Commits (3) - [`7ab0345`](https://github.com/netbox-community/netbox/commit/7ab034545019dafb3ccac2cf59e0f2fb937dd014) Issue #16934: Escape config-revision banner values by default - [`c85625b`](https://github.com/netbox-community/netbox/commit/c85625b3d3fa0df32369d4db57b232a2d6b1c2e5) Issue #16934: Escape config-revision banner values by default - [`56739d2`](https://github.com/netbox-community/netbox/commit/56739d2f1077a18277401c733ecd943597e56e83) Corrected info in docs/configuration/security.md to reflect that ESCAPE_BANNERS is new in v4.0.8 ### 📊 Changes **7 files changed** (+41 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `docs/configuration/security.md` (+11 -0) 📝 `netbox/core/forms/model_forms.py` (+5 -1) 📝 `netbox/netbox/configuration_example.py` (+3 -0) 📝 `netbox/netbox/settings.py` (+1 -0) 📝 `netbox/templates/base/layout.html` (+15 -3) 📝 `netbox/templates/login.html` (+5 -1) 📝 `netbox/utilities/error_handlers.py` (+1 -1) </details> ### 📄 Description ### Fixes: #16934 Escape config-revision banner values by default Fixes #16934 - Default to HTML-escaping banner values before displaying them - Also default to escaping banner values in config form previews - Escape names of dependent objects displayed when deleting parents - Update configuration docs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:07 +01:00
adam closed this issue 2025-12-30 00:19:08 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14956
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?