starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16938] [MERGED] Closes #16886: Dynamic event types #14953

New Issue
Closed
opened 2025-12-30 00:19:06 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:06 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16938
Author: @jeremystretch
Created: 7/18/2024
Status: ✅ Merged
Merged: 7/22/2024
Merged by: @jeremystretch

Base: feature ← Head: 16886-event-types

📝 Commits (9)

📊 Changes

22 files changed (+269 additions, -268 deletions)

View changed files

➕ docs/plugins/development/events.md (+16 -0)
📝 mkdocs.yml (+1 -0)
📝 netbox/core/events.py (+8 -8)
📝 netbox/extras/api/serializers_/events.py (+3 -3)
📝 netbox/extras/events.py (+7 -21)
📝 netbox/extras/filtersets.py (+7 -2)
📝 netbox/extras/forms/bulk_edit.py (+9 -23)
📝 netbox/extras/forms/bulk_import.py (+10 -4)
📝 netbox/extras/forms/filtersets.py (+7 -37)
📝 netbox/extras/forms/model_forms.py (+8 -12)
➕ netbox/extras/migrations/0119_eventrule_event_types.py (+75 -0)
📝 netbox/extras/models/models.py (+5 -32)
📝 netbox/extras/tables/tables.py (+7 -18)
📝 netbox/extras/tests/test_api.py (+7 -7)
📝 netbox/extras/tests/test_conditions.py (+5 -8)
📝 netbox/extras/tests/test_event_rules.py (+14 -15)
📝 netbox/extras/tests/test_filtersets.py (+10 -45)
📝 netbox/extras/tests/test_views.py (+8 -9)
📝 netbox/extras/views.py (+9 -0)
📝 netbox/netbox/events.py (+30 -0)

...and 2 more files

📄 Description

Fixes: #16886

  • Replace individual boolean fields on EventRule (type_create, type_update, etc.) with an event_types ArrayField
  • Document support for the registation of custom event types by plugins

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16938 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 7/18/2024 **Status:** ✅ Merged **Merged:** 7/22/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `16886-event-types` --- ### 📝 Commits (9) - [`8e2f459`](https://github.com/netbox-community/netbox/commit/8e2f459d100a05d1cbca2ac200bb2bb7f312a8bf) Initial work on #16886 - [`4fbc4e2`](https://github.com/netbox-community/netbox/commit/4fbc4e27b5b4443ee7bdf17cf94f50756076a141) Restore GraphQL filter - [`6302a10`](https://github.com/netbox-community/netbox/commit/6302a10a61aae4a10d4adf3aff44debe436c2cef) Remove namespace - [`41eff5c`](https://github.com/netbox-community/netbox/commit/41eff5c4c395af476947c668c184e922c32f15b1) Add Event documentation - [`1c2b82d`](https://github.com/netbox-community/netbox/commit/1c2b82dedd73d9b8161b68f9f152a3664551b8dc) Use MultipleChoiceField for event_types - [`36437c6`](https://github.com/netbox-community/netbox/commit/36437c644d661da15de8925a1748488d57c131d9) Fix event_types field class on EventRuleImportForm - [`b4e8a31`](https://github.com/netbox-community/netbox/commit/b4e8a3101a759d4fd587c57a0ae3df0491e14885) Fix tests - [`00dc9c4`](https://github.com/netbox-community/netbox/commit/00dc9c464b269effa37cb10acbf0a0386b0b6fce) Simplify event queue handling logic - [`d3668ce`](https://github.com/netbox-community/netbox/commit/d3668ce328b91ee9792d1c0e19027810b6763169) Misc cleanup ### 📊 Changes **22 files changed** (+269 additions, -268 deletions) <details> <summary>View changed files</summary> ➕ `docs/plugins/development/events.md` (+16 -0) 📝 `mkdocs.yml` (+1 -0) 📝 `netbox/core/events.py` (+8 -8) 📝 `netbox/extras/api/serializers_/events.py` (+3 -3) 📝 `netbox/extras/events.py` (+7 -21) 📝 `netbox/extras/filtersets.py` (+7 -2) 📝 `netbox/extras/forms/bulk_edit.py` (+9 -23) 📝 `netbox/extras/forms/bulk_import.py` (+10 -4) 📝 `netbox/extras/forms/filtersets.py` (+7 -37) 📝 `netbox/extras/forms/model_forms.py` (+8 -12) ➕ `netbox/extras/migrations/0119_eventrule_event_types.py` (+75 -0) 📝 `netbox/extras/models/models.py` (+5 -32) 📝 `netbox/extras/tables/tables.py` (+7 -18) 📝 `netbox/extras/tests/test_api.py` (+7 -7) 📝 `netbox/extras/tests/test_conditions.py` (+5 -8) 📝 `netbox/extras/tests/test_event_rules.py` (+14 -15) 📝 `netbox/extras/tests/test_filtersets.py` (+10 -45) 📝 `netbox/extras/tests/test_views.py` (+8 -9) 📝 `netbox/extras/views.py` (+9 -0) 📝 `netbox/netbox/events.py` (+30 -0) _...and 2 more files_ </details> ### 📄 Description ### Fixes: #16886 - Replace individual boolean fields on EventRule (`type_create`, `type_update`, etc.) with an `event_types` ArrayField - Document support for the registation of custom event types by plugins --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:06 +01:00
adam closed this issue 2025-12-30 00:19:06 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14953
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?