[PR #16942] [MERGED] Closes #16933: Enable toggling true/false marks on BooleanColumn #14951

New Issue

adam · 2025-12-30T00:19:06+01:00

adam commented

2025-12-30 00:19:06 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16942
Author: @jeremystretch
Created: 7/18/2024
Status: ✅ Merged
Merged: 7/19/2024
Merged by: @jeremystretch

Base: develop ← Head: 16933-boolean-column

📝 Commits (1)

c826857 Closes #16933: Enable toggling true/false marks on BooleanColumn

📊 Changes

8 files changed (+53 additions, -19 deletions)

View changed files

📝 netbox/core/tables/config.py (+1 -0)
📝 netbox/dcim/tables/devices.py (+8 -2)
📝 netbox/dcim/tables/devicetypes.py (+8 -3)
📝 netbox/extras/tables/tables.py (+7 -1)
📝 netbox/ipam/tables/ip.py (+10 -5)
📝 netbox/ipam/tables/vlans.py (+1 -0)
📝 netbox/ipam/tables/vrfs.py (+2 -1)
📝 netbox/netbox/tables/columns.py (+16 -7)

📄 Description

Fixes: #16933

Add true_mark and false_mark kwargs on BooleanColumn to allow disabling or customizing the checkmark/X icons
Disable the X icon on applicable existing boolean columns

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16942 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 7/18/2024 **Status:** ✅ Merged **Merged:** 7/19/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16933-boolean-column` --- ### 📝 Commits (1) - [`c826857`](https://github.com/netbox-community/netbox/commit/c8268575e5ab4b558749c8801a40cda286496029) Closes #16933: Enable toggling true/false marks on BooleanColumn ### 📊 Changes **8 files changed** (+53 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/tables/config.py` (+1 -0) 📝 `netbox/dcim/tables/devices.py` (+8 -2) 📝 `netbox/dcim/tables/devicetypes.py` (+8 -3) 📝 `netbox/extras/tables/tables.py` (+7 -1) 📝 `netbox/ipam/tables/ip.py` (+10 -5) 📝 `netbox/ipam/tables/vlans.py` (+1 -0) 📝 `netbox/ipam/tables/vrfs.py` (+2 -1) 📝 `netbox/netbox/tables/columns.py` (+16 -7) </details> ### 📄 Description ### Fixes: #16933 - Add `true_mark` and `false_mark` kwargs on BooleanColumn to allow disabling or customizing the checkmark/X icons - Disable the X icon on applicable existing boolean columns --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:19:06 +01:00

adam closed this issue

2025-12-30 00:19:06 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#14951