starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16875] [MERGED] 16849 document hierarchy issues #14938

New Issue
Closed
opened 2025-12-30 00:19:01 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:01 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16875
Author: @andrewgormley
Created: 7/10/2024
Status: ✅ Merged
Merged: 7/15/2024
Merged by: @jeremystretch

Base: feature-ui ← Head: 16849-document-hierarchy-issues

📝 Commits (6)

  • e0bf25d fixed #16849: h elements not in sequential order
  • f77b1bb fixed #16849: Lists do not contain only li elements
  • fa90ba5 fixed #16849: fixed h hierarchy on rack object pages
  • 06dbdd5 Merge branch 'feature-ui' into 16849-document-hierarchy-issues
  • a1e2cee Remove standalone h5 classes
  • f90b07e Remove unnecessary line breaks

📊 Changes

145 files changed (+358 additions, -358 deletions)

View changed files

📝 netbox/project-static/dist/netbox.css (+1 -1)
📝 netbox/project-static/styles/transitional/_cards.scss (+6 -0)
📝 netbox/project-static/styles/transitional/_forms.scss (+7 -0)
📝 netbox/templates/500.html (+2 -2)
📝 netbox/templates/account/base.html (+6 -7)
📝 netbox/templates/account/password.html (+3 -1)
📝 netbox/templates/account/preferences.html (+2 -2)
📝 netbox/templates/account/profile.html (+3 -3)
📝 netbox/templates/account/token.html (+1 -1)
📝 netbox/templates/base/40x.html (+2 -2)
📝 netbox/templates/circuits/circuit.html (+1 -1)
📝 netbox/templates/circuits/circuittype.html (+1 -1)
📝 netbox/templates/circuits/inc/circuit_termination.html (+2 -2)
📝 netbox/templates/circuits/provider.html (+3 -3)
📝 netbox/templates/circuits/provideraccount.html (+2 -2)
📝 netbox/templates/circuits/providernetwork.html (+2 -2)
📝 netbox/templates/core/configrevision.html (+2 -2)
📝 netbox/templates/core/datafile.html (+2 -2)
📝 netbox/templates/core/datasource.html (+3 -3)
📝 netbox/templates/core/job.html (+3 -3)

...and 80 more files

📄 Description

Fixes: #16849

  • (Misc) Lists do not contain only li elements [Multiple]
    The two main areas that were addressed were the tab navigation for the profile and object area and the related objects module on an object page. Both issues were fixed utilising role="presentation". It's worth noting this issue does not exist for tab navs on object list pages due to them utilising ids, roles and arias correctly due to the navigation happening in-page rather than linking elsewhere.

  • (Misc) Heading elements not in sequential descending order (h5 sub-header) [Multiple]
    This issue was occurring because pages were going from <h2> > <h5> and as far as I can tell the h tags were only being used for styling reasons. I've fixed this by changed the header block to use <h1> and changing the <h5> card headings to <h2> and added the existing class .h5 to ensure the styling remains the same.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16875 **Author:** [@andrewgormley](https://github.com/andrewgormley) **Created:** 7/10/2024 **Status:** ✅ Merged **Merged:** 7/15/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature-ui` ← **Head:** `16849-document-hierarchy-issues` --- ### 📝 Commits (6) - [`e0bf25d`](https://github.com/netbox-community/netbox/commit/e0bf25dea018a55747c2c731b969e8e4be84f595) fixed #16849: h elements not in sequential order - [`f77b1bb`](https://github.com/netbox-community/netbox/commit/f77b1bb4ea51d7a29c12094c53b36334d15d14a6) fixed #16849: Lists do not contain only li elements - [`fa90ba5`](https://github.com/netbox-community/netbox/commit/fa90ba5013708b876fe53b0608447d5bf6dd90e0) fixed #16849: fixed h hierarchy on rack object pages - [`06dbdd5`](https://github.com/netbox-community/netbox/commit/06dbdd584e344eeb74d9c1dc920ff187afd3c5d8) Merge branch 'feature-ui' into 16849-document-hierarchy-issues - [`a1e2cee`](https://github.com/netbox-community/netbox/commit/a1e2cee413441718be15f1927a82522752830d0f) Remove standalone h5 classes - [`f90b07e`](https://github.com/netbox-community/netbox/commit/f90b07e09ee60a8508f0a11fbab6c9467be109cb) Remove unnecessary line breaks ### 📊 Changes **145 files changed** (+358 additions, -358 deletions) <details> <summary>View changed files</summary> 📝 `netbox/project-static/dist/netbox.css` (+1 -1) 📝 `netbox/project-static/styles/transitional/_cards.scss` (+6 -0) 📝 `netbox/project-static/styles/transitional/_forms.scss` (+7 -0) 📝 `netbox/templates/500.html` (+2 -2) 📝 `netbox/templates/account/base.html` (+6 -7) 📝 `netbox/templates/account/password.html` (+3 -1) 📝 `netbox/templates/account/preferences.html` (+2 -2) 📝 `netbox/templates/account/profile.html` (+3 -3) 📝 `netbox/templates/account/token.html` (+1 -1) 📝 `netbox/templates/base/40x.html` (+2 -2) 📝 `netbox/templates/circuits/circuit.html` (+1 -1) 📝 `netbox/templates/circuits/circuittype.html` (+1 -1) 📝 `netbox/templates/circuits/inc/circuit_termination.html` (+2 -2) 📝 `netbox/templates/circuits/provider.html` (+3 -3) 📝 `netbox/templates/circuits/provideraccount.html` (+2 -2) 📝 `netbox/templates/circuits/providernetwork.html` (+2 -2) 📝 `netbox/templates/core/configrevision.html` (+2 -2) 📝 `netbox/templates/core/datafile.html` (+2 -2) 📝 `netbox/templates/core/datasource.html` (+3 -3) 📝 `netbox/templates/core/job.html` (+3 -3) _...and 80 more files_ </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be approved and assigned prior to opening a pull request. This helps avoid waste time and effort on a proposed change that we might not be able to accept. IF YOUR PULL REQUEST DOES NOT REFERENCE AN ISSUE WHICH HAS BEEN ASSIGNED TO YOU, IT WILL BE CLOSED AUTOMATICALLY. Please specify your assigned issue number on the line below. --> ### Fixes: #16849 <!-- Please include a summary of the proposed changes below. --> - [x] (Misc) Lists do not contain only li elements [Multiple] The two main areas that were addressed were the tab navigation for the profile and object area and the related objects module on an object page. Both issues were fixed utilising `role="presentation"`. It's worth noting this issue does not exist for tab navs on object list pages due to them utilising ids, roles and arias correctly due to the navigation happening in-page rather than linking elsewhere. - [x] (Misc) Heading elements not in sequential descending order (h5 sub-header) [Multiple] This issue was occurring because pages were going from `<h2>` > `<h5>` and as far as I can tell the h tags were only being used for styling reasons. I've fixed this by changed the header block to use `<h1>` and changing the `<h5>` card headings to `<h2>` and added the existing class `.h5` to ensure the styling remains the same. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:01 +01:00
adam closed this issue 2025-12-30 00:19:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14938
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?