[PR #16789] [MERGED] Fixes #16779: Fix saved filter selection for child object lists #14914

New Issue

adam · 2025-12-29T23:27:26+01:00

adam commented

2025-12-29 23:27:26 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16789
Author: @jeremystretch
Created: 7/2/2024
Status: ✅ Merged
Merged: 7/3/2024
Merged by: @jeremystretch

Base: develop ← Head: 16779-objectchildrenview-saved-filters

📝 Commits (2)

f190a23 Fixes #16779: Fix saved filter selection for child object lists
c76c909 Omit label_suffix

📊 Changes

7 files changed (+45 additions, -7 deletions)

View changed files

📝 netbox/dcim/views.py (+15 -0)
📝 netbox/ipam/views.py (+12 -0)
📝 netbox/netbox/views/generic/bulk_views.py (+1 -1)
📝 netbox/netbox/views/generic/object_views.py (+3 -0)
📝 netbox/templates/inc/table_controls_htmx.html (+8 -6)
📝 netbox/tenancy/views.py (+1 -0)
📝 netbox/virtualization/views.py (+5 -0)

📄 Description

Fixes: #16779

Add filterset_form attribute on ObjectChildrenView
Extend ObjectChildrenView to instantiate filter form
Define individual filter forms on all relevant ObjectChildrenView subclasses
Tweak template to hide saved filters selector if no filter form has been defined

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16789 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 7/2/2024 **Status:** ✅ Merged **Merged:** 7/3/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16779-objectchildrenview-saved-filters` --- ### 📝 Commits (2) - [`f190a23`](https://github.com/netbox-community/netbox/commit/f190a23a3e551d7564373848d92fb001614a85fb) Fixes #16779: Fix saved filter selection for child object lists - [`c76c909`](https://github.com/netbox-community/netbox/commit/c76c909a2fe607ab9ea68010728d2b751f2c56c0) Omit label_suffix ### 📊 Changes **7 files changed** (+45 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/views.py` (+15 -0) 📝 `netbox/ipam/views.py` (+12 -0) 📝 `netbox/netbox/views/generic/bulk_views.py` (+1 -1) 📝 `netbox/netbox/views/generic/object_views.py` (+3 -0) 📝 `netbox/templates/inc/table_controls_htmx.html` (+8 -6) 📝 `netbox/tenancy/views.py` (+1 -0) 📝 `netbox/virtualization/views.py` (+5 -0) </details> ### 📄 Description ### Fixes: #16779 - Add `filterset_form` attribute on ObjectChildrenView - Extend ObjectChildrenView to instantiate filter form - Define individual filter forms on all relevant ObjectChildrenView subclasses - Tweak template to hide saved filters selector if no filter form has been defined --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:27:26 +01:00

adam closed this issue

2025-12-29 23:27:27 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#14914