starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16763] [MERGED] 14731 plugins catalog #14909

New Issue
Closed
opened 2025-12-29 23:27:25 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:27:25 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16763
Author: @arthanson
Created: 6/28/2024
Status: ✅ Merged
Merged: 7/25/2024
Merged by: @jeremystretch

Base: feature ← Head: 14731-plugins-catalog

📝 Commits (10+)

📊 Changes

10 files changed (+490 additions, -42 deletions)

View changed files

➕ netbox/core/plugins.py (+209 -0)
📝 netbox/core/tables/plugins.py (+58 -17)
📝 netbox/core/urls.py (+4 -0)
📝 netbox/core/views.py (+54 -15)
📝 netbox/netbox/navigation/menu.py (+5 -0)
📝 netbox/netbox/settings.py (+2 -0)
➕ netbox/templates/core/inc/plugin_installation.html (+29 -0)
➕ netbox/templates/core/plugin.html (+113 -0)
➕ netbox/templates/core/plugin_list.html (+16 -0)
📝 netbox/templates/core/system.html (+0 -10)

📄 Description

Fixes: #14731

Changed from the design of cards to a standard table as per comments. Held off on writing tests as it is info display only and it sounds like we want to change to cards fairly soon which would require re-writing a lot of the tests. We could mock the API and check the display based on that, but not sure what really to test beyond that.

ACLs | NetBox 2024-06-28 08-28-16
ACLs | NetBox 2024-06-28 08-27-44
ACLs | NetBox 2024-06-28 08-27-59
Plugins | NetBox 2024-07-15 21-33-43

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16763 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 6/28/2024 **Status:** ✅ Merged **Merged:** 7/25/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `14731-plugins-catalog` --- ### 📝 Commits (10+) - [`6953c5e`](https://github.com/netbox-community/netbox/commit/6953c5e759d3c7ec707584c0c4d634d05cb3118d) 14731 plugin catalog - [`af601c5`](https://github.com/netbox-community/netbox/commit/af601c53a91b879e881847800640d75caef351bb) 14731 detal page - [`1a33b28`](https://github.com/netbox-community/netbox/commit/1a33b280f227cd25258492af28ac6b91f00ebde3) 14731 plugin table - [`1e26ae7`](https://github.com/netbox-community/netbox/commit/1e26ae79b012b3d0b3fd72aa3820382208c033b9) 14731 cleanup - [`0143a55`](https://github.com/netbox-community/netbox/commit/0143a5599ac6bb4c0c25a7dc6a465d9f20b115a9) 14731 cache API results - [`7be752a`](https://github.com/netbox-community/netbox/commit/7be752aba3cb41fa76fa699274e223069669e1fd) 14731 fix install name - [`577e9c7`](https://github.com/netbox-community/netbox/commit/577e9c71465de0aa4c83fa12cae84e50af0073dc) 14731 filtering - [`92fac68`](https://github.com/netbox-community/netbox/commit/92fac68817753dd9feaf62e663e1d3f08603f0bf) Merge branch 'feature' into 14731-plugins-catalog - [`3eacf36`](https://github.com/netbox-community/netbox/commit/3eacf360fcaafad503702e90adcac01390cb37c3) 14731 filtering - [`c38fa7f`](https://github.com/netbox-community/netbox/commit/c38fa7f9d3f382ef68e161544325ceef1fdd06d9) 14731 fix detail view ### 📊 Changes **10 files changed** (+490 additions, -42 deletions) <details> <summary>View changed files</summary> ➕ `netbox/core/plugins.py` (+209 -0) 📝 `netbox/core/tables/plugins.py` (+58 -17) 📝 `netbox/core/urls.py` (+4 -0) 📝 `netbox/core/views.py` (+54 -15) 📝 `netbox/netbox/navigation/menu.py` (+5 -0) 📝 `netbox/netbox/settings.py` (+2 -0) ➕ `netbox/templates/core/inc/plugin_installation.html` (+29 -0) ➕ `netbox/templates/core/plugin.html` (+113 -0) ➕ `netbox/templates/core/plugin_list.html` (+16 -0) 📝 `netbox/templates/core/system.html` (+0 -10) </details> ### 📄 Description ### Fixes: #14731 Changed from the design of cards to a standard table as per comments. Held off on writing tests as it is info display only and it sounds like we want to change to cards fairly soon which would require re-writing a lot of the tests. We could mock the API and check the display based on that, but not sure what really to test beyond that. ![ACLs | NetBox 2024-06-28 08-28-16](https://github.com/netbox-community/netbox/assets/99642/d78355b3-0989-476e-8426-ab8074b3d719) ![ACLs | NetBox 2024-06-28 08-27-44](https://github.com/netbox-community/netbox/assets/99642/856c581c-73ff-4e32-b859-3da9efd6b913) ![ACLs | NetBox 2024-06-28 08-27-59](https://github.com/netbox-community/netbox/assets/99642/581a0c98-a5e1-43b2-ae45-e3a162940f4c) <img width="1132" alt="Plugins | NetBox 2024-07-15 21-33-43" src="https://github.com/user-attachments/assets/673e1347-c1c9-4fa3-ac8b-469cbe1f8d9f"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:27:25 +01:00
adam closed this issue 2025-12-29 23:27:25 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14909
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?