starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16742] [CLOSED] 16660 - Use ngettext for strings with count #14899

New Issue
Closed
opened 2025-12-29 23:27:21 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:27:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16742
Author: @Julio-Oliveira-Encora
Created: 6/26/2024
Status: ❌ Closed

Base: develop ← Head: 16660-use-ngettext_for_strings_with_count

📝 Commits (4)

  • f0774c9 Added ngettext to error_handlers and clusters.py
  • 44c78b0 Added ngettext to utils.py
  • 15a7746 Added ngettext to device_components.py, devices.py, device_component_templates.py, and views.py
  • b642d16 Merge branch 'develop' into 16660-use-ngettext_for_strings_with_count

📊 Changes

7 files changed (+43 additions, -20 deletions)

View changed files

📝 netbox/dcim/models/device_component_templates.py (+6 -2)
📝 netbox/dcim/models/device_components.py (+7 -4)
📝 netbox/dcim/models/devices.py (+7 -4)
📝 netbox/dcim/views.py (+6 -2)
📝 netbox/utilities/error_handlers.py (+5 -2)
📝 netbox/utilities/forms/utils.py (+6 -2)
📝 netbox/virtualization/models/clusters.py (+6 -4)

📄 Description

Fixes: #16660

Added ngettext for strings with count, positions, and rows.

Please, feel free to indicate more places to add the ngettext.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16742 **Author:** [@Julio-Oliveira-Encora](https://github.com/Julio-Oliveira-Encora) **Created:** 6/26/2024 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `16660-use-ngettext_for_strings_with_count` --- ### 📝 Commits (4) - [`f0774c9`](https://github.com/netbox-community/netbox/commit/f0774c912e3706bc1f563dbe1bbafc7a1ef4a145) Added ngettext to error_handlers and clusters.py - [`44c78b0`](https://github.com/netbox-community/netbox/commit/44c78b084405e8fd575a346182d04134fb65e4da) Added ngettext to utils.py - [`15a7746`](https://github.com/netbox-community/netbox/commit/15a7746b29115ca266bed414f0c3ec53f4372fef) Added ngettext to device_components.py, devices.py, device_component_templates.py, and views.py - [`b642d16`](https://github.com/netbox-community/netbox/commit/b642d16ef420792459e22a87562fa0bf53f8a376) Merge branch 'develop' into 16660-use-ngettext_for_strings_with_count ### 📊 Changes **7 files changed** (+43 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models/device_component_templates.py` (+6 -2) 📝 `netbox/dcim/models/device_components.py` (+7 -4) 📝 `netbox/dcim/models/devices.py` (+7 -4) 📝 `netbox/dcim/views.py` (+6 -2) 📝 `netbox/utilities/error_handlers.py` (+5 -2) 📝 `netbox/utilities/forms/utils.py` (+6 -2) 📝 `netbox/virtualization/models/clusters.py` (+6 -4) </details> ### 📄 Description ### Fixes: #16660 Added `ngettext` for strings with `count`, `positions`, and `rows`. Please, feel free to indicate more places to add the `ngettext`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:27:21 +01:00
adam closed this issue 2025-12-29 23:27:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14899
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?