starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16703] [MERGED] Closes #16700: Audit usage of mark_safe() for consistent escaping #14886

New Issue
Closed
opened 2025-12-29 23:27:17 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:27:17 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16703
Author: @jeremystretch
Created: 6/24/2024
Status: ✅ Merged
Merged: 6/24/2024
Merged by: @jeremystretch

Base: develop ← Head: 16700-mark_safe-audit

📝 Commits (1)

  • 6886421 Closes #16700: Audit usage of mark_safe() for consistent escaping

📊 Changes

8 files changed (+16 additions, -13 deletions)

View changed files

📝 netbox/dcim/tables/cables.py (+2 -1)
📝 netbox/dcim/views.py (+3 -2)
📝 netbox/extras/models/customfields.py (+2 -1)
📝 netbox/extras/templatetags/custom_links.py (+4 -5)
📝 netbox/netbox/tables/columns.py (+1 -1)
📝 netbox/utilities/error_handlers.py (+1 -1)
📝 netbox/utilities/templatetags/builtins/filters.py (+1 -1)
📝 netbox/utilities/templatetags/mptt.py (+2 -1)

📄 Description

Fixes: #16700

  • Ensure any user-sourced data is passed through escape() first
  • Miscellaneous cleanup

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16703 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 6/24/2024 **Status:** ✅ Merged **Merged:** 6/24/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16700-mark_safe-audit` --- ### 📝 Commits (1) - [`6886421`](https://github.com/netbox-community/netbox/commit/68864213fb2886bcffe3805af1e565a3e7954e15) Closes #16700: Audit usage of mark_safe() for consistent escaping ### 📊 Changes **8 files changed** (+16 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/tables/cables.py` (+2 -1) 📝 `netbox/dcim/views.py` (+3 -2) 📝 `netbox/extras/models/customfields.py` (+2 -1) 📝 `netbox/extras/templatetags/custom_links.py` (+4 -5) 📝 `netbox/netbox/tables/columns.py` (+1 -1) 📝 `netbox/utilities/error_handlers.py` (+1 -1) 📝 `netbox/utilities/templatetags/builtins/filters.py` (+1 -1) 📝 `netbox/utilities/templatetags/mptt.py` (+2 -1) </details> ### 📄 Description ### Fixes: #16700 - Ensure any user-sourced data is passed through `escape()` first - Miscellaneous cleanup --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:27:17 +01:00
adam closed this issue 2025-12-29 23:27:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14886
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?