starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-12 05:20:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16662] [MERGED] Closes #16580: Remove AUTH_EXEMPT_PATHS #14877

New Issue
Closed
opened 2025-12-29 23:27:14 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:27:14 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16662
Author: @jeremystretch
Created: 6/19/2024
Status: ✅ Merged
Merged: 6/26/2024
Merged by: @jeremystretch

Base: feature ← Head: 16580-remove-auth_exempt_paths

📝 Commits (3)

  • 0714d8b Closes #16580: Remove AUTH_EXEMPT_PATHS
  • 16420a3 Merge branch 'feature' into 16580-remove-auth_exempt_paths
  • f32f2ed Misc cleanup

📊 Changes

7 files changed (+27 additions, -32 deletions)

View changed files

📝 netbox/extras/views.py (+1 -1)
📝 netbox/netbox/middleware.py (+0 -11)
📝 netbox/netbox/settings.py (+0 -9)
📝 netbox/netbox/views/generic/feature_views.py (+6 -5)
📝 netbox/netbox/views/htmx.py (+2 -1)
📝 netbox/netbox/views/misc.py (+3 -2)
📝 netbox/utilities/views.py (+15 -3)

📄 Description

Fixes: #16580

  • Remove the AUTH_EXEMPT_PATHS settings and its enforcement in middleware
  • Introduce ConditionalLoginRequiredMixin for enforcement of LOGIN_REQUIRED
  • Ensure that all applicable views inherit from either LoginRequiredMixin or ConditionalLoginRequiredMixin

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16662 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 6/19/2024 **Status:** ✅ Merged **Merged:** 6/26/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `16580-remove-auth_exempt_paths` --- ### 📝 Commits (3) - [`0714d8b`](https://github.com/netbox-community/netbox/commit/0714d8b021a202ba35d43e1f2ca8e1467e38fcc6) Closes #16580: Remove AUTH_EXEMPT_PATHS - [`16420a3`](https://github.com/netbox-community/netbox/commit/16420a32a115558f6f0a9e8f2c13f5dcdb247dbd) Merge branch 'feature' into 16580-remove-auth_exempt_paths - [`f32f2ed`](https://github.com/netbox-community/netbox/commit/f32f2ed1f30377f7fbe36f832427d6c607b5147a) Misc cleanup ### 📊 Changes **7 files changed** (+27 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/views.py` (+1 -1) 📝 `netbox/netbox/middleware.py` (+0 -11) 📝 `netbox/netbox/settings.py` (+0 -9) 📝 `netbox/netbox/views/generic/feature_views.py` (+6 -5) 📝 `netbox/netbox/views/htmx.py` (+2 -1) 📝 `netbox/netbox/views/misc.py` (+3 -2) 📝 `netbox/utilities/views.py` (+15 -3) </details> ### 📄 Description ### Fixes: #16580 - Remove the `AUTH_EXEMPT_PATHS` settings and its enforcement in middleware - Introduce ConditionalLoginRequiredMixin for enforcement of `LOGIN_REQUIRED` - Ensure that all applicable views inherit from either LoginRequiredMixin or ConditionalLoginRequiredMixin --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:27:14 +01:00
adam closed this issue 2025-12-29 23:27:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14877
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?