starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16639] [CLOSED] 15390 cable path #14872

New Issue
Closed
opened 2025-12-29 23:27:12 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:27:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16639
Author: @arthanson
Created: 6/18/2024
Status: ❌ Closed

Base: develop ← Head: 15390-cable-path

📝 Commits (5)

  • 82893ca 15390 send trace_paths if cable terminations updated
  • 1bd09b6 15390 send trace_paths if cable terminations updated
  • 0b48da8 Merge branch 'develop' into 15390-cable-path
  • deb6eb6 Merge branch 'develop' into 15390-cable-path
  • e5f5054 Merge branch 'develop' into 15390-cable-path

📊 Changes

1 file changed (+37 additions, -4 deletions)

View changed files

📝 netbox/dcim/models/cables.py (+37 -4)

📄 Description

Fixes: #15390

trace_paths signal handler needs to be called if CableTermination is updated effecting either cable or cable_end. Put in optimization logic as the signal is sent in Cable.save() which can create/update CableTermination so this would cause multiple redundant signal-handlers to be fired.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16639 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 6/18/2024 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `15390-cable-path` --- ### 📝 Commits (5) - [`82893ca`](https://github.com/netbox-community/netbox/commit/82893cab33d5247cfcf9b67b44a1ffde8cf7d536) 15390 send trace_paths if cable terminations updated - [`1bd09b6`](https://github.com/netbox-community/netbox/commit/1bd09b673b542cbeaa113846c02ef42c0c8f51cf) 15390 send trace_paths if cable terminations updated - [`0b48da8`](https://github.com/netbox-community/netbox/commit/0b48da8c49eb89c526cfee971fde0590e9a1935a) Merge branch 'develop' into 15390-cable-path - [`deb6eb6`](https://github.com/netbox-community/netbox/commit/deb6eb62e4ac456d8722a3a734ad0ddcb9bbf5fc) Merge branch 'develop' into 15390-cable-path - [`e5f5054`](https://github.com/netbox-community/netbox/commit/e5f50544797e263b2cacaf074d38a5d5ebeac83f) Merge branch 'develop' into 15390-cable-path ### 📊 Changes **1 file changed** (+37 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models/cables.py` (+37 -4) </details> ### 📄 Description ### Fixes: #15390 trace_paths signal handler needs to be called if CableTermination is updated effecting either cable or cable_end. Put in optimization logic as the signal is sent in Cable.save() which can create/update CableTermination so this would cause multiple redundant signal-handlers to be fired. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:27:12 +01:00
adam closed this issue 2025-12-29 23:27:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14872
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?