starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16545] [MERGED] Closes #16388: Move change logging resources from extras to core #14861

New Issue
Closed
opened 2025-12-29 23:27:09 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:27:09 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16545
Author: @jeremystretch
Created: 6/13/2024
Status: ✅ Merged
Merged: 6/17/2024
Merged by: @jeremystretch

Base: feature ← Head: 16388-move-change-logging

📝 Commits (2)

📊 Changes

63 files changed (+644 additions, -522 deletions)

View changed files

📝 netbox/account/views.py (+4 -2)
📝 netbox/core/api/serializers.py (+1 -0)
📝 netbox/core/api/serializers_/change_logging.py (+3 -3)
📝 netbox/core/api/urls.py (+1 -3)
📝 netbox/core/api/views.py (+11 -0)
📝 netbox/core/choices.py (+17 -0)
📝 netbox/core/filtersets.py (+41 -0)
📝 netbox/core/forms/filtersets.py (+39 -2)
📝 netbox/core/graphql/filters.py (+7 -0)
➕ netbox/core/graphql/mixins.py (+24 -0)
📝 netbox/core/graphql/types.py (+10 -0)
➕ netbox/core/migrations/0011_move_objectchange.py (+45 -0)
📝 netbox/core/models/__init__.py (+2 -1)
📝 netbox/core/models/change_logging.py (+4 -4)
➕ netbox/core/querysets.py (+26 -0)
📝 netbox/core/tables/__init__.py (+1 -0)
➕ netbox/core/tables/change_logging.py (+53 -0)
➕ netbox/core/tables/template_code.py (+16 -0)
📝 netbox/core/tests/test_changelog.py (+3 -2)
📝 netbox/core/tests/test_filtersets.py (+103 -1)

...and 43 more files

📄 Description

Fixes: #16388

  • Move the ObjectChange model & related resources (views, forms, tests, etc.) from the extras app to the core app
  • Write migrations to rename the existing table and avoid altering existing data
  • Move the event_tracking() context manager into netbox

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16545 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 6/13/2024 **Status:** ✅ Merged **Merged:** 6/17/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `16388-move-change-logging` --- ### 📝 Commits (2) - [`e7d1b7d`](https://github.com/netbox-community/netbox/commit/e7d1b7dde6a1f54e880d164d0533de0fca215564) Initial work on #16388 - [`68fcf3e`](https://github.com/netbox-community/netbox/commit/68fcf3e5101e68acaf6cdaa746f764287a7ec367) Misc cleanup ### 📊 Changes **63 files changed** (+644 additions, -522 deletions) <details> <summary>View changed files</summary> 📝 `netbox/account/views.py` (+4 -2) 📝 `netbox/core/api/serializers.py` (+1 -0) 📝 `netbox/core/api/serializers_/change_logging.py` (+3 -3) 📝 `netbox/core/api/urls.py` (+1 -3) 📝 `netbox/core/api/views.py` (+11 -0) 📝 `netbox/core/choices.py` (+17 -0) 📝 `netbox/core/filtersets.py` (+41 -0) 📝 `netbox/core/forms/filtersets.py` (+39 -2) 📝 `netbox/core/graphql/filters.py` (+7 -0) ➕ `netbox/core/graphql/mixins.py` (+24 -0) 📝 `netbox/core/graphql/types.py` (+10 -0) ➕ `netbox/core/migrations/0011_move_objectchange.py` (+45 -0) 📝 `netbox/core/models/__init__.py` (+2 -1) 📝 `netbox/core/models/change_logging.py` (+4 -4) ➕ `netbox/core/querysets.py` (+26 -0) 📝 `netbox/core/tables/__init__.py` (+1 -0) ➕ `netbox/core/tables/change_logging.py` (+53 -0) ➕ `netbox/core/tables/template_code.py` (+16 -0) 📝 `netbox/core/tests/test_changelog.py` (+3 -2) 📝 `netbox/core/tests/test_filtersets.py` (+103 -1) _...and 43 more files_ </details> ### 📄 Description ### Fixes: #16388 - Move the ObjectChange model & related resources (views, forms, tests, etc.) from the `extras` app to the `core` app - Write migrations to rename the existing table and avoid altering existing data - Move the `event_tracking()` context manager into `netbox` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:27:09 +01:00
adam closed this issue 2025-12-29 23:27:10 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14861
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?