starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16407] [MERGED] 7537 add serial number to virtual machines #14847

New Issue
Closed
opened 2025-12-29 23:27:05 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:27:05 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16407
Author: @arthanson
Created: 6/4/2024
Status: ✅ Merged
Merged: 6/12/2024
Merged by: @jeremystretch

Base: feature ← Head: 7537-vm-serial

📝 Commits (10+)

  • 583ab25 7537 add serial number to virtual machines
  • 26084f2 7537 add migration
  • 38b86f7 7537 add sn to search
  • 5116d21 7537 add to model documentation
  • 783b16a 8984 move serializer field
  • 47ebb51 8984 add to detail view and search index
  • f817e65 7537 serial_number -> serial
  • 768d55d Merge branch 'feature' into 7537-vm-serial
  • b2876ed 7537 fix migration
  • d54e3a1 Add missing serial field

📊 Changes

13 files changed (+65 additions, -17 deletions)

View changed files

📝 docs/models/virtualization/virtualmachine.md (+5 -0)
📝 netbox/templates/virtualization/virtualmachine.html (+4 -0)
📝 netbox/virtualization/api/serializers_/virtualmachines.py (+6 -6)
📝 netbox/virtualization/filtersets.py (+6 -2)
📝 netbox/virtualization/forms/bulk_import.py (+1 -1)
📝 netbox/virtualization/forms/filtersets.py (+5 -1)
📝 netbox/virtualization/forms/model_forms.py (+3 -3)
➕ netbox/virtualization/migrations/0040_virtualmachine_serial_number.py (+18 -0)
📝 netbox/virtualization/models/virtualmachines.py (+5 -0)
📝 netbox/virtualization/search.py (+2 -1)
📝 netbox/virtualization/tables/virtualmachines.py (+1 -1)
📝 netbox/virtualization/tests/test_filtersets.py (+8 -2)
📝 netbox/virtualization/tests/test_views.py (+1 -0)

📄 Description

Fixes: #7537

Added serial number field, kept it as non-unique? Wasn't sure if multiple vendors would have conflicting serial numbers if they aren't UUID, can change to unique if needed?

Didn't add to bulk edit as it didn't make sense to set multiple ones the same.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16407 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 6/4/2024 **Status:** ✅ Merged **Merged:** 6/12/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `7537-vm-serial` --- ### 📝 Commits (10+) - [`583ab25`](https://github.com/netbox-community/netbox/commit/583ab252cb91d177df8858f5a86ed853df43239a) 7537 add serial number to virtual machines - [`26084f2`](https://github.com/netbox-community/netbox/commit/26084f293c10c44970c819eb14261d09bdc2eefb) 7537 add migration - [`38b86f7`](https://github.com/netbox-community/netbox/commit/38b86f72ff344384317e829e086cbc9ef125b2bc) 7537 add sn to search - [`5116d21`](https://github.com/netbox-community/netbox/commit/5116d21b2b7623d7c287d638d6f691f89ac3b716) 7537 add to model documentation - [`783b16a`](https://github.com/netbox-community/netbox/commit/783b16ae5daeaba2224a7bfcbde5c9c0883bda16) 8984 move serializer field - [`47ebb51`](https://github.com/netbox-community/netbox/commit/47ebb51281bf88bab7083e30dbd2fee32d94d4f0) 8984 add to detail view and search index - [`f817e65`](https://github.com/netbox-community/netbox/commit/f817e657c6d83a2dacee354a1389e173cc976f20) 7537 serial_number -> serial - [`768d55d`](https://github.com/netbox-community/netbox/commit/768d55d3bed323d771d5675457e99e80472d80ae) Merge branch 'feature' into 7537-vm-serial - [`b2876ed`](https://github.com/netbox-community/netbox/commit/b2876edcdb140931939a4f0ef2a9a2b946246219) 7537 fix migration - [`d54e3a1`](https://github.com/netbox-community/netbox/commit/d54e3a139c47e8c39ed57e79338318ae946371a9) Add missing serial field ### 📊 Changes **13 files changed** (+65 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `docs/models/virtualization/virtualmachine.md` (+5 -0) 📝 `netbox/templates/virtualization/virtualmachine.html` (+4 -0) 📝 `netbox/virtualization/api/serializers_/virtualmachines.py` (+6 -6) 📝 `netbox/virtualization/filtersets.py` (+6 -2) 📝 `netbox/virtualization/forms/bulk_import.py` (+1 -1) 📝 `netbox/virtualization/forms/filtersets.py` (+5 -1) 📝 `netbox/virtualization/forms/model_forms.py` (+3 -3) ➕ `netbox/virtualization/migrations/0040_virtualmachine_serial_number.py` (+18 -0) 📝 `netbox/virtualization/models/virtualmachines.py` (+5 -0) 📝 `netbox/virtualization/search.py` (+2 -1) 📝 `netbox/virtualization/tables/virtualmachines.py` (+1 -1) 📝 `netbox/virtualization/tests/test_filtersets.py` (+8 -2) 📝 `netbox/virtualization/tests/test_views.py` (+1 -0) </details> ### 📄 Description ### Fixes: #7537 Added serial number field, kept it as non-unique? Wasn't sure if multiple vendors would have conflicting serial numbers if they aren't UUID, can change to unique if needed? Didn't add to bulk edit as it didn't make sense to set multiple ones the same. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:27:05 +01:00
adam closed this issue 2025-12-29 23:27:05 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14847
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?