starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16403] [CLOSED] 16307 - Restore ability for reports to be able to log_success without generating a message #14845

New Issue
Closed
opened 2025-12-29 23:27:04 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:27:04 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16403
Author: @Julio-Oliveira-Encora
Created: 6/4/2024
Status: ❌ Closed

Base: develop ← Head: 16307-Restore_ability_for_reports_to_be_able_to_log_success_without_generating_a_message

📝 Commits (7)

  • 2b3f2b1 Added check in views.py to bypass the log messages if the status is success and message is None.
  • 2caa413 Addressed PR comments
  • 4fa0c6d Merge branch 'develop' into 16307-Restore_ability_for_reports_to_be_able_to_log_success_without_generating_a_message
  • cfc87a7 Addressed PR comment.
  • f8aefb9 Merge branch 'develop' into 16307-Restore_ability_for_reports_to_be_able_to_log_success_without_generating_a_message
  • fe99ef8 Addressed PR comment.
  • 9a7c08a Addressed PR comment.

📊 Changes

3 files changed (+23 additions, -10 deletions)

View changed files

📝 docs/customization/reports.md (+11 -0)
📝 netbox/extras/reports.py (+10 -10)
📝 netbox/extras/views.py (+2 -0)

📄 Description

Fixes: #16307

It was added to bypass the log message when the status is success, and the message is None.

It was tested using log_success(None, None), log_success("", None), and log_sucess().

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16403 **Author:** [@Julio-Oliveira-Encora](https://github.com/Julio-Oliveira-Encora) **Created:** 6/4/2024 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `16307-Restore_ability_for_reports_to_be_able_to_log_success_without_generating_a_message` --- ### 📝 Commits (7) - [`2b3f2b1`](https://github.com/netbox-community/netbox/commit/2b3f2b11476d2529d83416d0c0f757dd4f09c96b) Added check in views.py to bypass the log messages if the status is success and message is None. - [`2caa413`](https://github.com/netbox-community/netbox/commit/2caa4131e8f01808605c92e5d1b0514362dcc6a7) Addressed PR comments - [`4fa0c6d`](https://github.com/netbox-community/netbox/commit/4fa0c6d4ee79a6865b877c4ef71a94a5b24384b9) Merge branch 'develop' into 16307-Restore_ability_for_reports_to_be_able_to_log_success_without_generating_a_message - [`cfc87a7`](https://github.com/netbox-community/netbox/commit/cfc87a7056a63c8466d6dedd9bc6d0a895bac3dc) Addressed PR comment. - [`f8aefb9`](https://github.com/netbox-community/netbox/commit/f8aefb906c9c4ec31d3dc2cbc55d1ba13daf7b43) Merge branch 'develop' into 16307-Restore_ability_for_reports_to_be_able_to_log_success_without_generating_a_message - [`fe99ef8`](https://github.com/netbox-community/netbox/commit/fe99ef81daa1a014cb3048ed5e5a39e14c83ff33) Addressed PR comment. - [`9a7c08a`](https://github.com/netbox-community/netbox/commit/9a7c08adb279a78a3c6c24f32743e453720186b9) Addressed PR comment. ### 📊 Changes **3 files changed** (+23 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `docs/customization/reports.md` (+11 -0) 📝 `netbox/extras/reports.py` (+10 -10) 📝 `netbox/extras/views.py` (+2 -0) </details> ### 📄 Description ### Fixes: #16307 It was added to bypass the log message when the status is success, and the message is None. It was tested using `log_success(None, None)`, `log_success("", None)`, and `log_sucess()`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:27:04 +01:00
adam closed this issue 2025-12-29 23:27:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14845
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?