starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16354] [MERGED] 16261 fix graphql lookup for MultiValueCharFilter fields #14839

New Issue
Closed
opened 2025-12-29 23:27:02 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:27:02 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16354
Author: @arthanson
Created: 5/29/2024
Status: ✅ Merged
Merged: 6/3/2024
Merged by: @jeremystretch

Base: develop ← Head: 16261-graphql-lookup

📝 Commits (5)

  • b8cfdcd 16261 fix graphql lookup for MultiValueCharFilter fields
  • d93569a 16261 fix graphql lookup for MultiValueCharFilter fields
  • 8f81418 16261 fixup test
  • e1911a5 16261 fixup test
  • 36b1854 Omit redundant assignment

📊 Changes

3 files changed (+14 additions, -5 deletions)

View changed files

📝 netbox/ipam/tests/test_api.py (+1 -1)
📝 netbox/netbox/graphql/filter_mixins.py (+3 -2)
📝 netbox/utilities/testing/api.py (+10 -2)

📄 Description

Fixes: #16261

Note: This requires lookups for string key filtering, for example you can't query device_list(filters: {name: "akron"}) { you have to do device_list(filters: {name: {i_contains: "akron"}}) {but this is consistent with the other string fields.

Monosnap GraphiQL | NetBox 2024-05-29 11-49-48

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16354 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 5/29/2024 **Status:** ✅ Merged **Merged:** 6/3/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16261-graphql-lookup` --- ### 📝 Commits (5) - [`b8cfdcd`](https://github.com/netbox-community/netbox/commit/b8cfdcd2ed7120da40fe287123523dfa57170e57) 16261 fix graphql lookup for MultiValueCharFilter fields - [`d93569a`](https://github.com/netbox-community/netbox/commit/d93569a5e1c01689af1d0770387b35453954babb) 16261 fix graphql lookup for MultiValueCharFilter fields - [`8f81418`](https://github.com/netbox-community/netbox/commit/8f8141875388e49c50e09a3ec3b6f3fbb3fd1286) 16261 fixup test - [`e1911a5`](https://github.com/netbox-community/netbox/commit/e1911a534bd0452a9e00748614a57aac8ee9161c) 16261 fixup test - [`36b1854`](https://github.com/netbox-community/netbox/commit/36b1854e6c97e2ef8ec04c4cc0413aad28aaca75) Omit redundant assignment ### 📊 Changes **3 files changed** (+14 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/tests/test_api.py` (+1 -1) 📝 `netbox/netbox/graphql/filter_mixins.py` (+3 -2) 📝 `netbox/utilities/testing/api.py` (+10 -2) </details> ### 📄 Description ### Fixes: #16261 **Note:** This requires lookups for string key filtering, for example you can't query `device_list(filters: {name: "akron"}) {` you have to do `device_list(filters: {name: {i_contains: "akron"}}) {`but this is consistent with the other string fields. ![Monosnap GraphiQL | NetBox 2024-05-29 11-49-48](https://github.com/netbox-community/netbox/assets/99642/61ce5897-add3-4441-941f-8bec9a9efb11) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:27:02 +01:00
adam closed this issue 2025-12-29 23:27:02 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14839
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?