starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16325] [MERGED] Closes #16290: Capture entire object in changelog data #14833

New Issue
Closed
opened 2025-12-29 23:27:00 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:27:00 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16325
Author: @jeremystretch
Created: 5/28/2024
Status: ✅ Merged
Merged: 5/29/2024
Merged by: @jeremystretch

Base: develop ← Head: 16290-improve-object-serialization

📝 Commits (1)

📊 Changes

8 files changed (+120 additions, -19 deletions)

View changed files

📝 netbox/extras/api/serializers_/change_logging.py (+10 -0)
📝 netbox/extras/models/change_logging.py (+71 -1)
📝 netbox/extras/tests/test_changelog.py (+28 -0)
📝 netbox/extras/views.py (+3 -3)
📝 netbox/project-static/dist/netbox.css (+1 -1)
📝 netbox/project-static/styles/custom/_code.scss (+2 -2)
📝 netbox/templates/extras/objectchange.html (+2 -2)
📝 netbox/utilities/serialization.py (+3 -10)

📄 Description

Fixes: #16290

  • Modify serialize_object() utility function so that it no longer excludes private/MPTT fields
  • Add "clean" attributes for pre- & post-change data on ObjectChange
  • Update the API serializers and UI views to display only the "clean" (non-private) change data
  • Extend changelog test to check for the presence of non-private data
  • Miscellaneous cosmetic tweaks

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16325 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 5/28/2024 **Status:** ✅ Merged **Merged:** 5/29/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16290-improve-object-serialization` --- ### 📝 Commits (1) - [`2fd82dc`](https://github.com/netbox-community/netbox/commit/2fd82dcc23d584a4d3147f1df1c201e9d712e060) Closes #16290: Capture entire object in changelog data ### 📊 Changes **8 files changed** (+120 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/api/serializers_/change_logging.py` (+10 -0) 📝 `netbox/extras/models/change_logging.py` (+71 -1) 📝 `netbox/extras/tests/test_changelog.py` (+28 -0) 📝 `netbox/extras/views.py` (+3 -3) 📝 `netbox/project-static/dist/netbox.css` (+1 -1) 📝 `netbox/project-static/styles/custom/_code.scss` (+2 -2) 📝 `netbox/templates/extras/objectchange.html` (+2 -2) 📝 `netbox/utilities/serialization.py` (+3 -10) </details> ### 📄 Description ### Fixes: #16290 - Modify `serialize_object()` utility function so that it no longer excludes private/MPTT fields - Add "clean" attributes for pre- & post-change data on ObjectChange - Update the API serializers and UI views to display only the "clean" (non-private) change data - Extend changelog test to check for the presence of non-private data - Miscellaneous cosmetic tweaks --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:27:00 +01:00
adam closed this issue 2025-12-29 23:27:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14833
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?