starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16270] [MERGED] 16202 fix mapit button for internationalized decimal seperator #14822

New Issue
Closed
opened 2025-12-29 23:26:56 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:26:56 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16270
Author: @arthanson
Created: 5/23/2024
Status: ✅ Merged
Merged: 5/29/2024
Merged by: @jeremystretch

Base: develop ← Head: 16202-mapit

📝 Commits (3)

  • 9fe3c9f 16202 fix mapit button for internationalized decimal seperator
  • 054362e 16202 revert untranslate
  • d50057b 16202 revert untranslate

📊 Changes

2 files changed (+4 additions, -2 deletions)

View changed files

📝 netbox/templates/dcim/device.html (+2 -1)
📝 netbox/templates/dcim/site.html (+2 -1)

📄 Description

Fixes: #16202

Used a filter function to get DECIMAL_SEPARATOR from Django as it could be something other then a comma.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16270 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 5/23/2024 **Status:** ✅ Merged **Merged:** 5/29/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16202-mapit` --- ### 📝 Commits (3) - [`9fe3c9f`](https://github.com/netbox-community/netbox/commit/9fe3c9fc8b7a507265e7be58a3fe1e25581f93c4) 16202 fix mapit button for internationalized decimal seperator - [`054362e`](https://github.com/netbox-community/netbox/commit/054362ec01642328698c76592c6b71e73e003abb) 16202 revert untranslate - [`d50057b`](https://github.com/netbox-community/netbox/commit/d50057b36f2dedb76a0ebecafde415836f14da58) 16202 revert untranslate ### 📊 Changes **2 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/dcim/device.html` (+2 -1) 📝 `netbox/templates/dcim/site.html` (+2 -1) </details> ### 📄 Description ### Fixes: #16202 Used a filter function to get DECIMAL_SEPARATOR from Django as it could be something other then a comma. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:26:56 +01:00
adam closed this issue 2025-12-29 23:26:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14822
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?