starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16239] [MERGED] Fixes #16232: Fix inclusion of bulk action checkboxes on dynamic tables #14818

New Issue
Closed
opened 2025-12-29 23:26:55 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:26:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16239
Author: @jeremystretch
Created: 5/22/2024
Status: ✅ Merged
Merged: 5/22/2024
Merged by: @jeremystretch

Base: develop ← Head: 16232-fix-htmx-table-checkboxes

📝 Commits (1)

  • ce00cb0 Fixes #16232: Fix inclusion of bulk action checkboxes on dynamic tables

📊 Changes

3 files changed (+6 additions, -4 deletions)

View changed files

📝 netbox/netbox/tables/tables.py (+4 -2)
📝 netbox/netbox/views/generic/bulk_views.py (+1 -1)
📝 netbox/utilities/templates/builtins/htmx_table.html (+1 -1)

📄 Description

Fixes: #16232

  • Update the htmx_table template tag used to embed object tables so that it passes embedded=True as a URL parameter.
  • Update the logic in ObjectListView to check for the presence of embedded=True rather than an HTMX target
  • Misc cleanup of NetBoxTable

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16239 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 5/22/2024 **Status:** ✅ Merged **Merged:** 5/22/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16232-fix-htmx-table-checkboxes` --- ### 📝 Commits (1) - [`ce00cb0`](https://github.com/netbox-community/netbox/commit/ce00cb0f80cc0ed996666c705634d8c6b8c866af) Fixes #16232: Fix inclusion of bulk action checkboxes on dynamic tables ### 📊 Changes **3 files changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/tables/tables.py` (+4 -2) 📝 `netbox/netbox/views/generic/bulk_views.py` (+1 -1) 📝 `netbox/utilities/templates/builtins/htmx_table.html` (+1 -1) </details> ### 📄 Description ### Fixes: #16232 - Update the `htmx_table` template tag used to embed object tables so that it passes `embedded=True` as a URL parameter. - Update the logic in ObjectListView to check for the presence of `embedded=True` rather than an HTMX target - Misc cleanup of NetBoxTable --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:26:55 +01:00
adam closed this issue 2025-12-29 23:26:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14818
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?