starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16121] [CLOSED] 14606 add id to GenericObjectSerializer #14784

New Issue
Closed
opened 2025-12-29 23:26:42 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:26:42 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16121
Author: @arthanson
Created: 5/14/2024
Status: ❌ Closed

Base: develop ← Head: 14606-generic-object-serializer

📝 Commits (2)

  • 3b767fd 14606 add id to GenericObjectSerializer
  • abf32d7 14606 add id to GenericObjectSerializer

📊 Changes

2 files changed (+8 additions, -0 deletions)

View changed files

📝 netbox/dcim/tests/test_api.py (+6 -0)
📝 netbox/netbox/api/serializers/generic.py (+2 -0)

📄 Description

Fixes: #14606

@jeremystretch Not sure if this is the correct fix - just returning the Id which is the same as the object_id. I think that is what is requested but seems like duplicated information.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16121 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 5/14/2024 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `14606-generic-object-serializer` --- ### 📝 Commits (2) - [`3b767fd`](https://github.com/netbox-community/netbox/commit/3b767fd7d3c41e15ea9fe77754af1d436c5b351a) 14606 add id to GenericObjectSerializer - [`abf32d7`](https://github.com/netbox-community/netbox/commit/abf32d7587a979731aa78ef7246eb21f0cfb9c56) 14606 add id to GenericObjectSerializer ### 📊 Changes **2 files changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/tests/test_api.py` (+6 -0) 📝 `netbox/netbox/api/serializers/generic.py` (+2 -0) </details> ### 📄 Description ### Fixes: #14606 @jeremystretch Not sure if this is the correct fix - just returning the Id which is the same as the object_id. I think that is what is requested but seems like duplicated information. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:26:42 +01:00
adam closed this issue 2025-12-29 23:26:42 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14784
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?