[PR #16049] [MERGED] 15973 fix switch type on cable edit #14764

New Issue

adam · 2025-12-29T23:26:36+01:00

adam commented

2025-12-29 23:26:36 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16049
Author: @arthanson
Created: 5/8/2024
Status: ✅ Merged
Merged: 5/9/2024
Merged by: @jeremystretch

Base: develop ← Head: 15973-cable

📝 Commits (2)

949c9f3 15973 fix switch type on cable edit
07288e4 15973 fix cable add from device

📊 Changes

1 file changed (+16 additions, -7 deletions)

View changed files

📝 netbox/dcim/forms/connections.py (+16 -7)

📄 Description

Fixes: #15973

A couple difference scenarios were causing issues with different fixes (now working):

Have a Circuit Termination and switch to a Console Port and have IDs of termination and console port matching - would leave Console Port field with value
Was originally popping terminations above in the existing if a_type checks, but that caused a blank a_terminations if you add a cable from a device.

This also looks like it fixes #15783 and will also resolve #13278

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16049 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 5/8/2024 **Status:** ✅ Merged **Merged:** 5/9/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `15973-cable` --- ### 📝 Commits (2) - [`949c9f3`](https://github.com/netbox-community/netbox/commit/949c9f3d5e32ffb2b5ed6bb5156e3585f4cd1fd4) 15973 fix switch type on cable edit - [`07288e4`](https://github.com/netbox-community/netbox/commit/07288e4b6130b74ba37d73b261c20780819881fd) 15973 fix cable add from device ### 📊 Changes **1 file changed** (+16 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms/connections.py` (+16 -7) </details> ### 📄 Description ### Fixes: #15973 A couple difference scenarios were causing issues with different fixes (now working): 1. Have a Circuit Termination and switch to a Console Port and have IDs of termination and console port matching - would leave Console Port field with value 2. Was originally popping terminations above in the existing if a_type checks, but that caused a blank a_terminations if you add a cable from a device. This also looks like it fixes #15783 and will also resolve #13278 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:26:36 +01:00

adam closed this issue

2025-12-29 23:26:36 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#14764