starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #16044] [MERGED] Fixes: #16039 - Fix row highlighting on device components and VM interfaces #14761

New Issue
Closed
opened 2025-12-29 23:26:35 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:26:35 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/16044
Author: @DanSheps
Created: 5/8/2024
Status: ✅ Merged
Merged: 6/3/2024
Merged by: @jeremystretch

Base: develop ← Head: 16039-fix-row-highlighting-on-device-components

📝 Commits (4)

  • 24ff722 Fix row highlighting
  • 668d173 Minor fix for VMInterfaces
  • 0a76d96 Move duplicated dicts into inheritable meta class
  • 7b0d7a6 Add CableTerminationTable.Meta class for inheritance of the row_attrs to each descendant Meta class.

📊 Changes

2 files changed (+16 additions, -32 deletions)

View changed files

📝 netbox/dcim/tables/devices.py (+14 -32)
📝 netbox/virtualization/tables/virtualmachines.py (+2 -0)

📄 Description

Fixes: #16039 - Fix row highlighting on device components and VM interfaces

  • Convert device component tables to utilize the same row highlighting technology that interfaces use
  • Convert VMInterfaceTable to utilize the same row highlighting technology that device interfaces use

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/16044 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 5/8/2024 **Status:** ✅ Merged **Merged:** 6/3/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16039-fix-row-highlighting-on-device-components` --- ### 📝 Commits (4) - [`24ff722`](https://github.com/netbox-community/netbox/commit/24ff722ffd5dc8f8671e0bfbb6f9672f4b62df5c) Fix row highlighting - [`668d173`](https://github.com/netbox-community/netbox/commit/668d1738f35a3f6cecd32384e0d3baa9bcc90c9e) Minor fix for VMInterfaces - [`0a76d96`](https://github.com/netbox-community/netbox/commit/0a76d962ce87b716a648a0154646bdd03fcf322b) Move duplicated dicts into inheritable meta class - [`7b0d7a6`](https://github.com/netbox-community/netbox/commit/7b0d7a60cbf973c21c5ba4b5bff0a375aacb6c45) Add CableTerminationTable.Meta class for inheritance of the row_attrs to each descendant Meta class. ### 📊 Changes **2 files changed** (+16 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/tables/devices.py` (+14 -32) 📝 `netbox/virtualization/tables/virtualmachines.py` (+2 -0) </details> ### 📄 Description Fixes: #16039 - Fix row highlighting on device components and VM interfaces * Convert device component tables to utilize the same row highlighting technology that interfaces use * Convert VMInterfaceTable to utilize the same row highlighting technology that device interfaces use --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:26:35 +01:00
adam closed this issue 2025-12-29 23:26:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14761
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?