starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15953] [MERGED] Fixes: #15948 - Fixes cable fanin/fanout when both are required #14732

New Issue
Closed
opened 2025-12-29 23:26:21 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:26:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15953
Author: @DanSheps
Created: 5/3/2024
Status: ✅ Merged
Merged: 5/6/2024
Merged by: @jeremystretch

Base: develop ← Head: 15948-fix-split-endpoint-cables

📝 Commits (2)

📊 Changes

1 file changed (+12 additions, -2 deletions)

View changed files

📝 netbox/dcim/svg/cables.py (+12 -2)

📄 Description

Fixes: #15948 - Fixes cable display when both fanin and fanout are required in cable trace

  • Adjust conditional to check for both fanin and fanout condition
  • Use my sucky maths to figure out a x_center for the fan-in/fan-out

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15953 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 5/3/2024 **Status:** ✅ Merged **Merged:** 5/6/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `15948-fix-split-endpoint-cables` --- ### 📝 Commits (2) - [`542a548`](https://github.com/netbox-community/netbox/commit/542a548abd4240cb6fc7fd7433ee1c6b5e0aa8e1) Preliminary fix for #15948 - [`fba3d11`](https://github.com/netbox-community/netbox/commit/fba3d111e5daaf7716f0a1c65c2fa2722ce85b8b) Tweaking of line height ### 📊 Changes **1 file changed** (+12 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/svg/cables.py` (+12 -2) </details> ### 📄 Description ### Fixes: #15948 - Fixes cable display when both fanin and fanout are required in cable trace * Adjust conditional to check for both fanin and fanout condition * Use my sucky maths to figure out a x_center for the fan-in/fan-out --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:26:21 +01:00
adam closed this issue 2025-12-29 23:26:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14732
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?