[PR #15913] [MERGED] Closes #15630: Remove server-side color mode preference & simplify toggling #14719

New Issue

adam · 2025-12-29T23:26:16+01:00

adam commented

2025-12-29 23:26:16 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15913
Author: @jeremystretch
Created: 5/1/2024
Status: ✅ Merged
Merged: 5/2/2024
Merged by: @jeremystretch

Base: feature ← Head: 15630-remove-color-mode-config

📝 Commits (1)

a1849d0 Closes #15630: Remove server-side color mode preference & simplify toggling

📊 Changes

8 files changed (+21 additions, -67 deletions)

View changed files

📝 docs/development/user-preferences.md (+0 -1)
📝 netbox/netbox/preferences.py (+0 -9)
📝 netbox/project-static/dist/netbox.js (+4 -4)
📝 netbox/project-static/dist/netbox.js.map (+1 -1)
📝 netbox/project-static/js/setmode.js (+13 -45)
📝 netbox/project-static/src/colorMode.ts (+2 -3)
📝 netbox/templates/base/base.html (+0 -3)
📝 netbox/users/forms/model_forms.py (+1 -1)

📄 Description

Fixes: #15630

Remove the ui.colormode preference
Remove the data-netbox-color-mode attribute from the <html> tag
Greatly simplify the logic necessary for determining whether light or dark mode is preferred

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15913 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 5/1/2024 **Status:** ✅ Merged **Merged:** 5/2/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `15630-remove-color-mode-config` --- ### 📝 Commits (1) - [`a1849d0`](https://github.com/netbox-community/netbox/commit/a1849d0798f40e4bbbeeebc6ac3fa57c8153ec21) Closes #15630: Remove server-side color mode preference & simplify toggling ### 📊 Changes **8 files changed** (+21 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `docs/development/user-preferences.md` (+0 -1) 📝 `netbox/netbox/preferences.py` (+0 -9) 📝 `netbox/project-static/dist/netbox.js` (+4 -4) 📝 `netbox/project-static/dist/netbox.js.map` (+1 -1) 📝 `netbox/project-static/js/setmode.js` (+13 -45) 📝 `netbox/project-static/src/colorMode.ts` (+2 -3) 📝 `netbox/templates/base/base.html` (+0 -3) 📝 `netbox/users/forms/model_forms.py` (+1 -1) </details> ### 📄 Description ### Fixes: #15630 - Remove the `ui.colormode` preference - Remove the `data-netbox-color-mode` attribute from the `<html>` tag - _Greatly_ simplify the logic necessary for determining whether light or dark mode is preferred --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:26:16 +01:00

adam closed this issue

2025-12-29 23:26:16 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#14719