[PR #15900] [MERGED] 15873 - Make Cluster resource counters more readable #14714

Closed
opened 2025-12-29 23:26:14 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15900
Author: @Julio-Oliveira-Encora
Created: 4/30/2024
Status: Merged
Merged: 6/6/2024
Merged by: @jeremystretch

Base: developHead: 15873-make_cluster_resource_counters_more_readable


📝 Commits (10+)

  • 1ba2dd0 Created "convert_byte_size" method to convert the memory and disk size according to unit informed.
  • 07305f9 Changed decimal size for memory_sum and disk_sum
  • 2567ef2 Added test for convert_byte_size.
  • 1ad6376 Merge branch 'develop' into 15873-make_cluster_resource_counters_more_readable
  • 872f1e9 Fixed
  • c91c25d Addressed PR comments.
  • d3e9906 Addressed PR comments.
  • deb6e99 Linter issues for helpers.py
  • 8e3d8ab Merge branch 'develop' into 15873-make_cluster_resource_counters_more_readable
  • a1fd983 Changed humanize_megabytes

📊 Changes

3 files changed (+16 additions, -14 deletions)

View changed files

📝 netbox/templates/virtualization/cluster.html (+1 -1)
📝 netbox/templates/virtualization/virtualmachine.html (+1 -1)
📝 netbox/utilities/templatetags/helpers.py (+14 -12)

📄 Description

Fixes: #15873

One method was created to normalize the VM's disk and memory sizes according to their units. That method is applied when the "Allocated Resources" is generated.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15900 **Author:** [@Julio-Oliveira-Encora](https://github.com/Julio-Oliveira-Encora) **Created:** 4/30/2024 **Status:** ✅ Merged **Merged:** 6/6/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `15873-make_cluster_resource_counters_more_readable` --- ### 📝 Commits (10+) - [`1ba2dd0`](https://github.com/netbox-community/netbox/commit/1ba2dd04fa24ad3768d0e7e945b7aff39797f26e) Created "convert_byte_size" method to convert the memory and disk size according to unit informed. - [`07305f9`](https://github.com/netbox-community/netbox/commit/07305f9037ac2c52d1b162968c30137f82ea2750) Changed decimal size for memory_sum and disk_sum - [`2567ef2`](https://github.com/netbox-community/netbox/commit/2567ef297cd4e2c0d12c4129217e16d95551ec82) Added test for convert_byte_size. - [`1ad6376`](https://github.com/netbox-community/netbox/commit/1ad63761ea71f889ccb237c6298a4479be554057) Merge branch 'develop' into 15873-make_cluster_resource_counters_more_readable - [`872f1e9`](https://github.com/netbox-community/netbox/commit/872f1e9800598bc25d3e26dde52f2a8d5fb3dd36) Fixed - [`c91c25d`](https://github.com/netbox-community/netbox/commit/c91c25d059749090305a029070b8711ee2e451c3) Addressed PR comments. - [`d3e9906`](https://github.com/netbox-community/netbox/commit/d3e9906af3335a916ccbcea344cbdcbaaa135a8d) Addressed PR comments. - [`deb6e99`](https://github.com/netbox-community/netbox/commit/deb6e9922cbe610f53e26c96a359a00ed90292ef) Linter issues for helpers.py - [`8e3d8ab`](https://github.com/netbox-community/netbox/commit/8e3d8ab6eda353aa9d687d63b5c31331a9c5a7d9) Merge branch 'develop' into 15873-make_cluster_resource_counters_more_readable - [`a1fd983`](https://github.com/netbox-community/netbox/commit/a1fd983173caa10825a7097e77cd03732e1ac37f) Changed humanize_megabytes ### 📊 Changes **3 files changed** (+16 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/virtualization/cluster.html` (+1 -1) 📝 `netbox/templates/virtualization/virtualmachine.html` (+1 -1) 📝 `netbox/utilities/templatetags/helpers.py` (+14 -12) </details> ### 📄 Description ### Fixes: #15873 One method was created to normalize the VM's disk and memory sizes according to their units. That method is applied when the "Allocated Resources" is generated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:26:14 +01:00
adam closed this issue 2025-12-29 23:26:14 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14714