starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15902] [MERGED] 15831 monkeypatch LDAP _mirror_group function for NB4 #14713

New Issue
Closed
opened 2025-12-29 23:26:13 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:26:13 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15902
Author: @arthanson
Created: 4/30/2024
Status: ✅ Merged
Merged: 5/2/2024
Merged by: @jeremystretch

Base: feature ← Head: 15831-ldap-mirror-groups

📝 Commits (6)

  • 1e6be99 15831 monkeypatch LDAP _mirror_group function for NB4
  • 7807edf 15831 monkeypatch LDAP _mirror_group function for NB4
  • addc514 15831 monkeypatch LDAP _mirror_group function for NB4
  • 169e312 Move the modified _mirror_groups() method to a separate module to retain license
  • 633a0a4 15831 fix import
  • 43bd883 15831 fix import

📊 Changes

2 files changed (+73 additions, -1 deletions)

View changed files

📝 netbox/netbox/authentication/__init__.py (+6 -1)
➕ netbox/netbox/authentication/misc.py (+67 -0)

📄 Description

Fixes: #15831

Mokey-patches _mirror_groups from django-auth-ldap to use NetBox Group instead of the Django.auth one. Code is directly from django-auth-ldap, no changes except for the import statement above the function definition.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15902 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 4/30/2024 **Status:** ✅ Merged **Merged:** 5/2/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `15831-ldap-mirror-groups` --- ### 📝 Commits (6) - [`1e6be99`](https://github.com/netbox-community/netbox/commit/1e6be996ae4dcae9d8993a4e703468833ccc0750) 15831 monkeypatch LDAP _mirror_group function for NB4 - [`7807edf`](https://github.com/netbox-community/netbox/commit/7807edf552c4c6928b1a2ef6ba4586f42b70a90c) 15831 monkeypatch LDAP _mirror_group function for NB4 - [`addc514`](https://github.com/netbox-community/netbox/commit/addc5149bef4f7fc5ed209f1664c9581a5b84cc3) 15831 monkeypatch LDAP _mirror_group function for NB4 - [`169e312`](https://github.com/netbox-community/netbox/commit/169e31259634ef10454500b318ebf75e8fd46dea) Move the modified _mirror_groups() method to a separate module to retain license - [`633a0a4`](https://github.com/netbox-community/netbox/commit/633a0a40023c7a63403e3f2acab5418cac64b1da) 15831 fix import - [`43bd883`](https://github.com/netbox-community/netbox/commit/43bd883e79910c5e77b7e3c26fcd14a383ca0cd0) 15831 fix import ### 📊 Changes **2 files changed** (+73 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/authentication/__init__.py` (+6 -1) ➕ `netbox/netbox/authentication/misc.py` (+67 -0) </details> ### 📄 Description ### Fixes: #15831 Mokey-patches _mirror_groups from django-auth-ldap to use NetBox Group instead of the Django.auth one. Code is directly from django-auth-ldap, no changes except for the import statement above the function definition. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:26:13 +01:00
adam closed this issue 2025-12-29 23:26:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14713
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?