starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15779] [MERGED] 15764 change vc_position from PositiveSmallInteger to PositiveInteger #14676

New Issue
Closed
opened 2025-12-29 23:25:55 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:25:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15779
Author: @arthanson
Created: 4/19/2024
Status: ✅ Merged
Merged: 4/19/2024
Merged by: @jeremystretch

Base: feature ← Head: 15764-vc-position

📝 Commits (1)

  • 48907bc 15764 change vc_position from PositiveSmallInteger to PositiveInteger

📊 Changes

2 files changed (+19 additions, -2 deletions)

View changed files

➕ netbox/dcim/migrations/0187_alter_device_vc_position.py (+18 -0)
📝 netbox/dcim/models/devices.py (+1 -2)

📄 Description

Fixes: #15764

Change vc_position from PositiveSmallInteger to PositiveInteger - form field and serializer are already IntegerField so no changes needed there.

Note: We had talked about min-value of 1, but there was no min-value currently on the field and the serializer has min-value of 0 so it's possible someone already has 0 in the DB so didn't want to change.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15779 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 4/19/2024 **Status:** ✅ Merged **Merged:** 4/19/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `15764-vc-position` --- ### 📝 Commits (1) - [`48907bc`](https://github.com/netbox-community/netbox/commit/48907bcf2eb7ec3743e7c59b43b81154d0b417f2) 15764 change vc_position from PositiveSmallInteger to PositiveInteger ### 📊 Changes **2 files changed** (+19 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `netbox/dcim/migrations/0187_alter_device_vc_position.py` (+18 -0) 📝 `netbox/dcim/models/devices.py` (+1 -2) </details> ### 📄 Description ### Fixes: #15764 Change vc_position from PositiveSmallInteger to PositiveInteger - form field and serializer are already IntegerField so no changes needed there. Note: We had talked about min-value of 1, but there was no min-value currently on the field and the serializer has min-value of 0 so it's possible someone already has 0 in the DB so didn't want to change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:25:55 +01:00
adam closed this issue 2025-12-29 23:25:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14676
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?