starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15768] [MERGED] 15588 set readonly nullable fields as allow_null=True #14675

New Issue
Closed
opened 2025-12-29 23:25:54 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:25:54 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15768
Author: @arthanson
Created: 4/19/2024
Status: ✅ Merged
Merged: 4/19/2024
Merged by: @jeremystretch

Base: develop ← Head: 15588-nullable-openapi

📝 Commits (1)

  • 73bc9db 15588 set readonly nullable fields as allow_null=True

📊 Changes

3 files changed (+10 additions, -10 deletions)

View changed files

📝 netbox/dcim/api/serializers.py (+4 -4)
📝 netbox/ipam/api/serializers.py (+5 -5)
📝 netbox/virtualization/api/serializers.py (+1 -1)

📄 Description

Fixes: #15588

As mentioned in the bug report, several fields are readonly but can also allow null return. I did a scan through the code and tried to identify all issues of this - checking that the model can actually return a null for those fields.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15768 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 4/19/2024 **Status:** ✅ Merged **Merged:** 4/19/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `15588-nullable-openapi` --- ### 📝 Commits (1) - [`73bc9db`](https://github.com/netbox-community/netbox/commit/73bc9db1da7b36d2cb39851a8e05e8c8694ee6eb) 15588 set readonly nullable fields as allow_null=True ### 📊 Changes **3 files changed** (+10 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/api/serializers.py` (+4 -4) 📝 `netbox/ipam/api/serializers.py` (+5 -5) 📝 `netbox/virtualization/api/serializers.py` (+1 -1) </details> ### 📄 Description ### Fixes: #15588 As mentioned in the bug report, several fields are readonly but can also allow null return. I did a scan through the code and tried to identify all issues of this - checking that the model can actually return a null for those fields. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:25:54 +01:00
adam closed this issue 2025-12-29 23:25:54 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14675
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?