starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15724] [CLOSED] Fixes 15652 - PROTECTION_RULES: Custom Validator does not show error message on object deletion #14654

New Issue
Closed
opened 2025-12-29 23:25:46 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:25:46 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15724
Author: @Julio-Oliveira-Encora
Created: 4/15/2024
Status: ❌ Closed

Base: feature ← Head: 15652-custom_validator_does_not_show_error_message_on_object_deletion

📝 Commits (2)

  • 2214b8a It was replaced the lines 428 and 433 with "return redirect(self.get_return_url(request))". The toast is displayed with the message if the IP Address is protected.
  • 2b7c7ce It was replaced the lines 433 with "return redirect(self.get_return_url(request))". The toast is displayed with the message if the IP Address is protected.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/netbox/views/generic/object_views.py (+1 -1)

📄 Description

Fixes: #15652

The issue was solved by replacing the line 433 of "netbox/netbox/views/generic/object_views.py" with "return redirect(self.get_return_url(request))".

Please let me know if I should also replace line 428 of the same file.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15724 **Author:** [@Julio-Oliveira-Encora](https://github.com/Julio-Oliveira-Encora) **Created:** 4/15/2024 **Status:** ❌ Closed **Base:** `feature` ← **Head:** `15652-custom_validator_does_not_show_error_message_on_object_deletion` --- ### 📝 Commits (2) - [`2214b8a`](https://github.com/netbox-community/netbox/commit/2214b8ad5f1c896ca13d299701bda630069cd2e9) It was replaced the lines 428 and 433 with "return redirect(self.get_return_url(request))". The toast is displayed with the message if the IP Address is protected. - [`2b7c7ce`](https://github.com/netbox-community/netbox/commit/2b7c7ceab4e37366041575c0b0c6eb05f67d89c2) It was replaced the lines 433 with "return redirect(self.get_return_url(request))". The toast is displayed with the message if the IP Address is protected. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/views/generic/object_views.py` (+1 -1) </details> ### 📄 Description ### Fixes: #15652 The issue was solved by replacing the line 433 of "netbox/netbox/views/generic/object_views.py" with "return redirect(self.get_return_url(request))". **_Please let me know if I should also replace line 428 of the same file._** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:25:46 +01:00
adam closed this issue 2025-12-29 23:25:46 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14654
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?