starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15557] [MERGED] 15553 change graphql sub-queries from functions to types #14615

New Issue
Closed
opened 2025-12-29 23:25:31 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:25:31 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15557
Author: @arthanson
Created: 3/28/2024
Status: ✅ Merged
Merged: 3/29/2024
Merged by: @jeremystretch

Base: feature ← Head: 15553-graphql-sub-queries

📝 Commits (2)

  • 0406a6f 15553 change graphql list to types
  • 24b7ca0 15553 review changes

📊 Changes

14 files changed (+226 additions, -799 deletions)

View changed files

📝 netbox/circuits/graphql/types.py (+8 -27)
📝 netbox/core/graphql/types.py (+1 -3)
📝 netbox/dcim/graphql/mixins.py (+4 -8)
📝 netbox/dcim/graphql/types.py (+106 -371)
📝 netbox/extras/graphql/mixins.py (+2 -6)
📝 netbox/extras/graphql/types.py (+20 -76)
📝 netbox/ipam/graphql/mixins.py (+2 -6)
📝 netbox/ipam/graphql/types.py (+31 -114)
📝 netbox/tenancy/graphql/mixins.py (+1 -3)
📝 netbox/tenancy/graphql/types.py (+26 -101)
📝 netbox/users/graphql/types.py (+1 -3)
📝 netbox/virtualization/graphql/types.py (+10 -35)
📝 netbox/vpn/graphql/types.py (+12 -40)
📝 netbox/wireless/graphql/types.py (+2 -6)

📄 Description

Fixes: #15553

GraphQL filtering doesn't work on functions, so define sub-queries as types.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15557 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 3/28/2024 **Status:** ✅ Merged **Merged:** 3/29/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `15553-graphql-sub-queries` --- ### 📝 Commits (2) - [`0406a6f`](https://github.com/netbox-community/netbox/commit/0406a6f4dbb7c3b84590199408e2dedabc4163d5) 15553 change graphql list to types - [`24b7ca0`](https://github.com/netbox-community/netbox/commit/24b7ca03e511bc23b58b6ee304fc52aec5dea100) 15553 review changes ### 📊 Changes **14 files changed** (+226 additions, -799 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/graphql/types.py` (+8 -27) 📝 `netbox/core/graphql/types.py` (+1 -3) 📝 `netbox/dcim/graphql/mixins.py` (+4 -8) 📝 `netbox/dcim/graphql/types.py` (+106 -371) 📝 `netbox/extras/graphql/mixins.py` (+2 -6) 📝 `netbox/extras/graphql/types.py` (+20 -76) 📝 `netbox/ipam/graphql/mixins.py` (+2 -6) 📝 `netbox/ipam/graphql/types.py` (+31 -114) 📝 `netbox/tenancy/graphql/mixins.py` (+1 -3) 📝 `netbox/tenancy/graphql/types.py` (+26 -101) 📝 `netbox/users/graphql/types.py` (+1 -3) 📝 `netbox/virtualization/graphql/types.py` (+10 -35) 📝 `netbox/vpn/graphql/types.py` (+12 -40) 📝 `netbox/wireless/graphql/types.py` (+2 -6) </details> ### 📄 Description ### Fixes: #15553 GraphQL filtering doesn't work on functions, so define sub-queries as types. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:25:31 +01:00
adam closed this issue 2025-12-29 23:25:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14615
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?