starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15480] [MERGED] Closes #15339: Consume entire viewport #14605

New Issue
Closed
opened 2025-12-29 23:25:27 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:25:27 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15480
Author: @jeremystretch
Created: 3/19/2024
Status: ✅ Merged
Merged: 3/20/2024
Merged by: @jeremystretch

Base: feature ← Head: 15339-variable-page-widths

📝 Commits (2)

  • 606d1dd Closes #15339: Consume entire viewport, except for object detail views
  • 3af2919 Use fluid containers for all views

📊 Changes

8 files changed (+15 additions, -13 deletions)

View changed files

📝 netbox/templates/base/layout.html (+3 -3)
📝 netbox/templates/core/rq_task_list.html (+1 -1)
📝 netbox/templates/core/rq_worker_list.html (+1 -1)
📝 netbox/templates/extras/script_result.html (+1 -1)
📝 netbox/templates/generic/_base.html (+2 -2)
📝 netbox/templates/generic/bulk_delete.html (+1 -1)
📝 netbox/templates/generic/bulk_remove.html (+5 -3)
📝 netbox/templates/generic/object.html (+1 -1)

📄 Description

Fixes: #15339

  • Tweak the base templates to render to the full width of the viewport ("fluid") by default
  • Introduce the page_width context variable to override this for object detail views

I'm not super happy with this solution, but it seems the only feasible choice without upending our entire template structure.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15480 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 3/19/2024 **Status:** ✅ Merged **Merged:** 3/20/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `15339-variable-page-widths` --- ### 📝 Commits (2) - [`606d1dd`](https://github.com/netbox-community/netbox/commit/606d1dded3811c43b19a290725db1b6182f47438) Closes #15339: Consume entire viewport, except for object detail views - [`3af2919`](https://github.com/netbox-community/netbox/commit/3af291940ea9df9fedcafa552acaaa3171d6a4cf) Use fluid containers for all views ### 📊 Changes **8 files changed** (+15 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/base/layout.html` (+3 -3) 📝 `netbox/templates/core/rq_task_list.html` (+1 -1) 📝 `netbox/templates/core/rq_worker_list.html` (+1 -1) 📝 `netbox/templates/extras/script_result.html` (+1 -1) 📝 `netbox/templates/generic/_base.html` (+2 -2) 📝 `netbox/templates/generic/bulk_delete.html` (+1 -1) 📝 `netbox/templates/generic/bulk_remove.html` (+5 -3) 📝 `netbox/templates/generic/object.html` (+1 -1) </details> ### 📄 Description ### Fixes: #15339 - Tweak the base templates to render to the full width of the viewport ("fluid") by default - Introduce the `page_width` context variable to override this for object detail views I'm not super happy with this solution, but it seems the only feasible choice without upending our entire template structure. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:25:27 +01:00
adam closed this issue 2025-12-29 23:25:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14605
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?