starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15341] [MERGED] Closes #14871: Complete work on UI cleanup #14576

New Issue
Closed
opened 2025-12-29 23:25:17 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:25:17 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15341
Author: @jeremystretch
Created: 3/4/2024
Status: ✅ Merged
Merged: 3/4/2024
Merged by: @jeremystretch

Base: feature ← Head: 14871-ui-cleanup

📝 Commits (10+)

  • 9fca84b Fix left padding of login button in top menu
  • ae101e9 Relocate "add" buttons for embedded object tables
  • 1c7bdac Merge branch 'feature' into 14871-ui-cleanup
  • 136217e Remove unused data template block & getNetboxData() utility function
  • 3aadf59 Remove bottom margin from last

    element in rendered Markdown inside a table cell

  • eef79d7 Prevent TomSelect from initializing on elements with a size 48b3ad1 Fix styling of dropdown menu button for circuit commit rate a55460b Change .color-block to display: inline-block 3afed96 Delete unused static asset 6ba83a9 Improve contrast between menu group headings & items 📊 Changes 19 files changed (+39 additions, -56 deletions) View changed files 📝 netbox/project-static/dist/netbox.css (+1 -1) 📝 netbox/project-static/dist/netbox.js (+4 -4) 📝 netbox/project-static/dist/netbox.js.map (+1 -1) ➖ netbox/project-static/img/tint_20.png (+0 -0) 📝 netbox/project-static/src/objectSelector.ts (+6 -5) 📝 netbox/project-static/src/select/dynamic.ts (+1 -1) 📝 netbox/project-static/src/select/static.ts (+2 -2) 📝 netbox/project-static/src/util.ts (+0 -23) 📝 netbox/project-static/styles/custom/_markdown.scss (+7 -0) 📝 netbox/project-static/styles/custom/_misc.scss (+1 -1) 📝 netbox/project-static/styles/overrides/_tabler.scss (+4 -0) 📝 netbox/project-static/styles/transitional/_tables.scss (+0 -1) 📝 netbox/templates/base/base.html (+0 -5) 📝 netbox/templates/dcim/rack.html (+1 -1) 📝 netbox/templates/dcim/rack_elevation_list.html (+5 -7) 📝 netbox/templates/inc/toast.html (+1 -1) 📝 netbox/utilities/templates/form_helpers/render_field.html (+1 -1) 📝 netbox/utilities/templates/navigation/menu.html (+1 -1) 📝 netbox/utilities/templates/widgets/number_with_options.html (+3 -1) 📄 Description Closes: #14871 This completes the remaining checklist items in #14871 and closes out the blanket review initiative. Moving forward, any UI issues will need to be submitted as individual bug reports. 🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15341 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 3/4/2024 **Status:** ✅ Merged **Merged:** 3/4/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `14871-ui-cleanup` --- ### 📝 Commits (10+) - [`9fca84b`](https://github.com/netbox-community/netbox/commit/9fca84be9b4c339ad0a82e6fd371b7dd7fa5f298) Fix left padding of login button in top menu - [`ae101e9`](https://github.com/netbox-community/netbox/commit/ae101e93e498993e5eea0006e17f7952af64be73) Relocate "add" buttons for embedded object tables - [`1c7bdac`](https://github.com/netbox-community/netbox/commit/1c7bdac6c7e34bcec4ec7c6974b847d80e4389cc) Merge branch 'feature' into 14871-ui-cleanup - [`136217e`](https://github.com/netbox-community/netbox/commit/136217e9b2a9802e908024921dd48acea77c6beb) Remove unused data template block & getNetboxData() utility function - [`3aadf59`](https://github.com/netbox-community/netbox/commit/3aadf59b15ef8c5a0648365079170803299727df) Remove bottom margin from last <p> element in rendered Markdown inside a table cell - [`eef79d7`](https://github.com/netbox-community/netbox/commit/eef79d7cbc20c333155abd083e0aa37981bb6e13) Prevent TomSelect from initializing on <select> elements with a size - [`48b3ad1`](https://github.com/netbox-community/netbox/commit/48b3ad17b717648ef4666ccbd156cb6015b849d9) Fix styling of dropdown menu button for circuit commit rate - [`a55460b`](https://github.com/netbox-community/netbox/commit/a55460bee78d187aafe74c5c5de61c9965e99957) Change .color-block to display: inline-block - [`3afed96`](https://github.com/netbox-community/netbox/commit/3afed96181ba6b33e0f97221a48efc624175107b) Delete unused static asset - [`6ba83a9`](https://github.com/netbox-community/netbox/commit/6ba83a9b56454b4efc824eaba88dc5084b13d18e) Improve contrast between menu group headings & items ### 📊 Changes **19 files changed** (+39 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `netbox/project-static/dist/netbox.css` (+1 -1) 📝 `netbox/project-static/dist/netbox.js` (+4 -4) 📝 `netbox/project-static/dist/netbox.js.map` (+1 -1) ➖ `netbox/project-static/img/tint_20.png` (+0 -0) 📝 `netbox/project-static/src/objectSelector.ts` (+6 -5) 📝 `netbox/project-static/src/select/dynamic.ts` (+1 -1) 📝 `netbox/project-static/src/select/static.ts` (+2 -2) 📝 `netbox/project-static/src/util.ts` (+0 -23) 📝 `netbox/project-static/styles/custom/_markdown.scss` (+7 -0) 📝 `netbox/project-static/styles/custom/_misc.scss` (+1 -1) 📝 `netbox/project-static/styles/overrides/_tabler.scss` (+4 -0) 📝 `netbox/project-static/styles/transitional/_tables.scss` (+0 -1) 📝 `netbox/templates/base/base.html` (+0 -5) 📝 `netbox/templates/dcim/rack.html` (+1 -1) 📝 `netbox/templates/dcim/rack_elevation_list.html` (+5 -7) 📝 `netbox/templates/inc/toast.html` (+1 -1) 📝 `netbox/utilities/templates/form_helpers/render_field.html` (+1 -1) 📝 `netbox/utilities/templates/navigation/menu.html` (+1 -1) 📝 `netbox/utilities/templates/widgets/number_with_options.html` (+3 -1) </details> ### 📄 Description ### Closes: #14871 This completes the remaining checklist items in #14871 and closes out the blanket review initiative. Moving forward, any UI issues will need to be submitted as individual bug reports. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:25:17 +01:00
adam closed this issue 2025-12-29 23:25:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14576
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?