starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15183] [MERGED] Fixes: #14058 - Limits platform selection to manufacturer and platforms with no manufacturer #14540

New Issue
Closed
opened 2025-12-29 23:25:05 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:25:05 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15183
Author: @DanSheps
Created: 2/17/2024
Status: ✅ Merged
Merged: 2/20/2024
Merged by: @jeremystretch

Base: develop ← Head: 14058-limit-platform-to-manufacturer

📝 Commits (2)

  • 31ad711 Fixes: #14058 - Limits platform selection to manufacturer and platforms with no manufacturer
  • b6a9818 Apply suggestions from code review

📊 Changes

3 files changed (+35 additions, -2 deletions)

View changed files

📝 netbox/dcim/filtersets.py (+14 -0)
📝 netbox/dcim/forms/model_forms.py (+9 -2)
📝 netbox/dcim/tests/test_filtersets.py (+12 -0)

📄 Description

Fixes: #14058 - Limits platform selection to manufacturer and platforms with no manufacturer

  • Add new filter(s):
    • get_for_device_type
    • get_for_manufacturer
  • Configure form to utilize new filters
  • Add tests

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15183 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 2/17/2024 **Status:** ✅ Merged **Merged:** 2/20/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `14058-limit-platform-to-manufacturer` --- ### 📝 Commits (2) - [`31ad711`](https://github.com/netbox-community/netbox/commit/31ad7119e70f3c1b3c168e7b205706c55820cda7) Fixes: #14058 - Limits platform selection to manufacturer and platforms with no manufacturer - [`b6a9818`](https://github.com/netbox-community/netbox/commit/b6a981895a298f2b66cf6ac63b23d69cc9c0e451) Apply suggestions from code review ### 📊 Changes **3 files changed** (+35 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/filtersets.py` (+14 -0) 📝 `netbox/dcim/forms/model_forms.py` (+9 -2) 📝 `netbox/dcim/tests/test_filtersets.py` (+12 -0) </details> ### 📄 Description ### Fixes: #14058 - Limits platform selection to manufacturer and platforms with no manufacturer * Add new filter(s): * get_for_device_type * get_for_manufacturer * Configure form to utilize new filters * Add tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:25:05 +01:00
adam closed this issue 2025-12-29 23:25:05 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14540
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?