starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15196] [MERGED] Fixes #15090: Run deletion protection rules prior to enqueueing events #14539

New Issue
Closed
opened 2025-12-29 23:25:04 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:25:04 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15196
Author: @jeremystretch
Created: 2/20/2024
Status: ✅ Merged
Merged: 2/20/2024
Merged by: @jeremystretch

Base: develop ← Head: 15090-protected-deletion-webhooks

📝 Commits (1)

  • e44d77c Fixes #15090: Run deletion protection rules prior to enqueueing events

📊 Changes

2 files changed (+36 additions, -33 deletions)

View changed files

📝 netbox/extras/signals.py (+16 -33)
📝 netbox/extras/validators.py (+20 -0)

📄 Description

Fixes: #15090

  • Move run_validators() to extras.validators
  • Absorb run_delete_validators() logic into handle_deleted_object(), ensuring that it is executed before events are enqueued

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15196 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 2/20/2024 **Status:** ✅ Merged **Merged:** 2/20/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `15090-protected-deletion-webhooks` --- ### 📝 Commits (1) - [`e44d77c`](https://github.com/netbox-community/netbox/commit/e44d77c37eb6d0a23bce3f11d35b98dc67f46079) Fixes #15090: Run deletion protection rules prior to enqueueing events ### 📊 Changes **2 files changed** (+36 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/signals.py` (+16 -33) 📝 `netbox/extras/validators.py` (+20 -0) </details> ### 📄 Description ### Fixes: #15090 - Move `run_validators()` to `extras.validators` - Absorb `run_delete_validators()` logic into `handle_deleted_object()`, ensuring that it is executed before events are enqueued --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:25:04 +01:00
adam closed this issue 2025-12-29 23:25:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14539
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?