[PR #15166] [MERGED] Fixes #14079: Explicitly remove M2M assignments to objects being deleted to ensure change logging #14536

New Issue

adam · 2025-12-29T23:25:04+01:00

adam commented

2025-12-29 23:25:04 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15166
Author: @jeremystretch
Created: 2/15/2024
Status: ✅ Merged
Merged: 2/16/2024
Merged by: @jeremystretch

Base: develop ← Head: 14079-fix-reverse-m2m-change-logging

📝 Commits (1)

832bf61 Fixes #14079: Explicitly remove M2M assignments to objects being deleted to ensure change logging

📊 Changes

1 file changed (+22 additions, -1 deletions)

View changed files

📝 netbox/extras/signals.py (+22 -1)

📄 Description

Fixes: #14079

This extends the handle_deleted_object() signal receiver to inspect objects being deleted for reverse many-to-many relationships. For any that are found, we query the related model for objects associated with the object being deleted, and manually delete the association by calling remove() on the remote M2M field. This triggers an m2m_changed signal for the related object, ensuring that the change is logged.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15166 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 2/15/2024 **Status:** ✅ Merged **Merged:** 2/16/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `14079-fix-reverse-m2m-change-logging` --- ### 📝 Commits (1) - [`832bf61`](https://github.com/netbox-community/netbox/commit/832bf613217b0a48cb168a0dcb56403e656b09b7) Fixes #14079: Explicitly remove M2M assignments to objects being deleted to ensure change logging ### 📊 Changes **1 file changed** (+22 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/signals.py` (+22 -1) </details> ### 📄 Description ### Fixes: #14079 This extends the `handle_deleted_object()` signal receiver to inspect objects being deleted for reverse many-to-many relationships. For any that are found, we query the related model for objects associated with the object being deleted, and manually delete the association by calling `remove()` on the remote M2M field. This triggers an `m2m_changed` signal for the related object, ensuring that the change is logged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:25:04 +01:00

adam closed this issue

2025-12-29 23:25:04 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#14536