starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #15032] [MERGED] Closes #13729: Censor sensitive data source parameters in change log #14509

New Issue
Closed
opened 2025-12-29 23:24:53 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:24:53 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/15032
Author: @jeremystretch
Created: 2/2/2024
Status: ✅ Merged
Merged: 2/5/2024
Merged by: @jeremystretch

Base: develop ← Head: 13729-data-source-credentials

📝 Commits (1)

  • ca26033 Closes #13729: Censor sensitive data source parameters in change log

📊 Changes

3 files changed (+149 additions, -0 deletions)

View changed files

📝 netbox/core/models/data.py (+23 -0)
➕ netbox/core/tests/test_models.py (+122 -0)
📝 netbox/netbox/constants.py (+4 -0)

📄 Description

Fixes: #13729

This overrides the to_objectchange() method on DataSource to censor the values of any parameters designated as sensitive for the assigned backend. We're doing this here rather than directly in serialize_object() because we need to determine whether each sensitive value has been modified.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/15032 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 2/2/2024 **Status:** ✅ Merged **Merged:** 2/5/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `13729-data-source-credentials` --- ### 📝 Commits (1) - [`ca26033`](https://github.com/netbox-community/netbox/commit/ca260337326b055019eed68211fabd809f3f7ca9) Closes #13729: Censor sensitive data source parameters in change log ### 📊 Changes **3 files changed** (+149 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/models/data.py` (+23 -0) ➕ `netbox/core/tests/test_models.py` (+122 -0) 📝 `netbox/netbox/constants.py` (+4 -0) </details> ### 📄 Description ### Fixes: #13729 This overrides the `to_objectchange()` method on DataSource to censor the values of any parameters designated as sensitive for the assigned backend. We're doing this here rather than directly in `serialize_object()` because we need to determine whether each sensitive value has been modified. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:24:53 +01:00
adam closed this issue 2025-12-29 23:24:53 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14509
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?