starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14976] [MERGED] 12510 Merge Scripts and Reports #14491

New Issue
Closed
opened 2025-12-29 23:24:47 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:24:47 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14976
Author: @arthanson
Created: 1/30/2024
Status: ✅ Merged
Merged: 2/7/2024
Merged by: @jeremystretch

Base: feature ← Head: 12510-reports

📝 Commits (10+)

📊 Changes

26 files changed (+571 additions, -1272 deletions)

View changed files

📝 docs/customization/custom-scripts.md (+76 -7)
📝 docs/customization/reports.md (+36 -140)
📝 mkdocs.yml (+1 -0)
📝 netbox/extras/api/serializers.py (+0 -18)
📝 netbox/extras/api/urls.py (+0 -1)
📝 netbox/extras/api/views.py (+0 -106)
📝 netbox/extras/choices.py (+13 -0)
➖ netbox/extras/management/commands/runreport.py (+0 -65)
📝 netbox/extras/management/commands/runscript.py (+12 -3)
➕ netbox/extras/migrations/0107_convert_reports_to_scripts.py (+31 -0)
📝 netbox/extras/models/__init__.py (+0 -1)
➖ netbox/extras/models/reports.py (+0 -80)
📝 netbox/extras/models/scripts.py (+3 -1)
📝 netbox/extras/reports.py (+16 -231)
📝 netbox/extras/scripts.py (+166 -32)
📝 netbox/extras/tests/test_api.py (+0 -31)
📝 netbox/extras/urls.py (+0 -9)
📝 netbox/extras/utils.py (+3 -2)
📝 netbox/extras/views.py (+17 -188)
📝 netbox/netbox/navigation/menu.py (+1 -7)

...and 6 more files

📄 Description

Fixes: #12510

Combined scripts and reports and adds the report summary of logs to scripts.

Note: used unassigned for logs that are in the main or have no method assigned (report logs all are tied to the test_methods). Not really liking the 'unassigned' name, alternative suggestions welcome.

The old job data record is different for reports and scripts, created a new one for the combined and put in legacy_ templates for the older ones.

Monosnap Scripts | NetBox 2024-01-30 08-25-38

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14976 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 1/30/2024 **Status:** ✅ Merged **Merged:** 2/7/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `12510-reports` --- ### 📝 Commits (10+) - [`1b8849a`](https://github.com/netbox-community/netbox/commit/1b8849a43b8e485c1857aeeb69b0da995c9c6d09) 12510 move reports to use BaseScript - [`32678b3`](https://github.com/netbox-community/netbox/commit/32678b3c4bbd4c0cf8972797e9632bdf770f8bf4) Merge branch 'feature' into 12510-reports - [`c692055`](https://github.com/netbox-community/netbox/commit/c69205535ea6180bc12b60bcaefa8cec6632fdeb) 12510 merge report into script view - [`ab14a8a`](https://github.com/netbox-community/netbox/commit/ab14a8a71c78e76db29f2520eeec6ee079c280f3) 12510 add migration for job report to script - [`8a990d7`](https://github.com/netbox-community/netbox/commit/8a990d7372544c6ce21403a2512cbee6a48e31a3) 12510 update templates - [`73190fa`](https://github.com/netbox-community/netbox/commit/73190fa99651a58310b2ab39c9ea4f1039310cd9) 12510 remove reports - [`23a8b2a`](https://github.com/netbox-community/netbox/commit/23a8b2a9298c14618e0da392fe05ef9c68e0a010) 12510 cleanup - [`5268961`](https://github.com/netbox-community/netbox/commit/52689616e99c1477fccc33002d13be9b5da30f80) 12510 legacy jobs - [`e61b960`](https://github.com/netbox-community/netbox/commit/e61b960cd72268d2cd11285bff2a7ae26f0a2a7b) 12510 legacy jobs - [`53b3875`](https://github.com/netbox-community/netbox/commit/53b3875e82606b9ab3ed231cfaf218c0c4df6365) 12510 fixes ### 📊 Changes **26 files changed** (+571 additions, -1272 deletions) <details> <summary>View changed files</summary> 📝 `docs/customization/custom-scripts.md` (+76 -7) 📝 `docs/customization/reports.md` (+36 -140) 📝 `mkdocs.yml` (+1 -0) 📝 `netbox/extras/api/serializers.py` (+0 -18) 📝 `netbox/extras/api/urls.py` (+0 -1) 📝 `netbox/extras/api/views.py` (+0 -106) 📝 `netbox/extras/choices.py` (+13 -0) ➖ `netbox/extras/management/commands/runreport.py` (+0 -65) 📝 `netbox/extras/management/commands/runscript.py` (+12 -3) ➕ `netbox/extras/migrations/0107_convert_reports_to_scripts.py` (+31 -0) 📝 `netbox/extras/models/__init__.py` (+0 -1) ➖ `netbox/extras/models/reports.py` (+0 -80) 📝 `netbox/extras/models/scripts.py` (+3 -1) 📝 `netbox/extras/reports.py` (+16 -231) 📝 `netbox/extras/scripts.py` (+166 -32) 📝 `netbox/extras/tests/test_api.py` (+0 -31) 📝 `netbox/extras/urls.py` (+0 -9) 📝 `netbox/extras/utils.py` (+3 -2) 📝 `netbox/extras/views.py` (+17 -188) 📝 `netbox/netbox/navigation/menu.py` (+1 -7) _...and 6 more files_ </details> ### 📄 Description ### Fixes: #12510 Combined scripts and reports and adds the report summary of logs to scripts. **Note:** used unassigned for logs that are in the main or have no method assigned (report logs all are tied to the test_methods). Not really liking the 'unassigned' name, alternative suggestions welcome. The old job data record is different for reports and scripts, created a new one for the combined and put in legacy_ templates for the older ones. ![Monosnap Scripts | NetBox 2024-01-30 08-25-38](https://github.com/netbox-community/netbox/assets/99642/d9f903d0-fd0d-4806-9c6c-5c42f7f2ee59) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:24:47 +01:00
adam closed this issue 2025-12-29 23:24:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14491
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?