starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14870] [MERGED] Fixes #14829 Simple condition (without and/or) does not work in event rule #14471

New Issue
Closed
opened 2025-12-29 23:24:40 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:24:40 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14870
Author: @Julio-Oliveira-Encora
Created: 1/19/2024
Status: ✅ Merged
Merged: 6/7/2024
Merged by: @arthanson

Base: develop ← Head: 14829-simple_condition_without_and_or_does_not_work_in_event_rule

📝 Commits (10+)

  • cbde1be Changed ConditionSet in conditions.py to allow conditions without logical operator. Added some tests.
  • b14c447 Addressed comments in the PR.
  • 8998a34 Addressed comments in the PR.
  • f2f8e10 Develop merged
  • 5fd8dce Moved tests from test_event_rules.py to test_conditions.py.
  • 3df04ef Merge branch 'develop' into 14829-simple_condition_without_and_or_does_not_work_in_event_rule
  • 270bd53 Addressed PR comments.
  • e94b2f3 Addressed PR comments.
  • 287565c Merge branch 'develop' into 14829-simple_condition_without_and_or_does_not_work_in_event_rule
  • ccc6cf3 Addressed PR comment.

📊 Changes

2 files changed (+112 additions, -16 deletions)

View changed files

📝 netbox/extras/conditions.py (+16 -16)
📝 netbox/extras/tests/test_conditions.py (+96 -0)

📄 Description

Fixes: #14829

This change allows the addition of simple conditions in the Event Rule. Currently, it only allows to add conditions with logical operators.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14870 **Author:** [@Julio-Oliveira-Encora](https://github.com/Julio-Oliveira-Encora) **Created:** 1/19/2024 **Status:** ✅ Merged **Merged:** 6/7/2024 **Merged by:** [@arthanson](https://github.com/arthanson) **Base:** `develop` ← **Head:** `14829-simple_condition_without_and_or_does_not_work_in_event_rule` --- ### 📝 Commits (10+) - [`cbde1be`](https://github.com/netbox-community/netbox/commit/cbde1bebeeadf4dda9ba9eb1b088adbc69d678f4) Changed ConditionSet in conditions.py to allow conditions without logical operator. Added some tests. - [`b14c447`](https://github.com/netbox-community/netbox/commit/b14c447fcfb22c719cc5b4a28b3d6705b9fdbc39) Addressed comments in the PR. - [`8998a34`](https://github.com/netbox-community/netbox/commit/8998a34b02f9013577b84bcc0e906f52668b6ce0) Addressed comments in the PR. - [`f2f8e10`](https://github.com/netbox-community/netbox/commit/f2f8e10f68e1dece80d612f2af8823363d667747) Develop merged - [`5fd8dce`](https://github.com/netbox-community/netbox/commit/5fd8dced0c494aec128f084c3f1d56bc2a35b32d) Moved tests from test_event_rules.py to test_conditions.py. - [`3df04ef`](https://github.com/netbox-community/netbox/commit/3df04efecc8f1c3d81098d0261b269a20205ca9f) Merge branch 'develop' into 14829-simple_condition_without_and_or_does_not_work_in_event_rule - [`270bd53`](https://github.com/netbox-community/netbox/commit/270bd533014b7a3b59f1252eae0207c19b9fddbf) Addressed PR comments. - [`e94b2f3`](https://github.com/netbox-community/netbox/commit/e94b2f39d080ac769997200d835b96a84a3d2268) Addressed PR comments. - [`287565c`](https://github.com/netbox-community/netbox/commit/287565c10843345813f4ea8c01098b4e8d5adf7e) Merge branch 'develop' into 14829-simple_condition_without_and_or_does_not_work_in_event_rule - [`ccc6cf3`](https://github.com/netbox-community/netbox/commit/ccc6cf3d4fa5a80e0786eb83a1745ccdbcffa06e) Addressed PR comment. ### 📊 Changes **2 files changed** (+112 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/conditions.py` (+16 -16) 📝 `netbox/extras/tests/test_conditions.py` (+96 -0) </details> ### 📄 Description ### Fixes: #14829 This change allows the addition of simple conditions in the Event Rule. Currently, it only allows to add conditions with logical operators. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:24:40 +01:00
adam closed this issue 2025-12-29 23:24:40 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14471
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?