starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #14754] [MERGED] Fixes #14572 - Constrains JobView (and related views) badge to specific named job #14450

New Issue
Closed
opened 2025-12-29 23:24:32 +01:00 by adam · 0 comments
adam commented 2025-12-29 23:24:32 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/14754
Author: @DanSheps
Created: 1/9/2024
Status: ✅ Merged
Merged: 1/22/2024
Merged by: @jeremystretch

Base: develop ← Head: 14572-fix-script-job-count

📝 Commits (10+)

  • 8a14000 Fixes #14572 - Constrains JobView (and related views) badge to specific named job
  • 5c3da7a Adjust report views to resolve same problem
  • 44cf93a Fixed PEP8 error
  • 1c2b460 Update netbox/templates/extras/script/base.html
  • a2086e7 Move function to method on PythonModuleMixin
  • 7560f4a Update netbox/extras/views.py
  • 8918b11 Update netbox/extras/views.py
  • 33075a0 Update netbox/extras/views.py
  • 206db57 Update netbox/extras/views.py
  • 6f85dbb Update to mixin and view

📊 Changes

4 files changed (+31 additions, -27 deletions)

View changed files

📝 netbox/extras/models/mixins.py (+10 -0)
📝 netbox/extras/views.py (+19 -25)
📝 netbox/templates/extras/report/base.html (+1 -1)
📝 netbox/templates/extras/script/base.html (+1 -1)

📄 Description

Fixes: #14572 - Constrains JobView to specific job

  • Create new method to return relevant jobs
  • Call method to provide 'jobs' key for rendered context data

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/14754 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 1/9/2024 **Status:** ✅ Merged **Merged:** 1/22/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `14572-fix-script-job-count` --- ### 📝 Commits (10+) - [`8a14000`](https://github.com/netbox-community/netbox/commit/8a140009d01b45fd91174f9a3cdef696584b9a2d) Fixes #14572 - Constrains JobView (and related views) badge to specific named job - [`5c3da7a`](https://github.com/netbox-community/netbox/commit/5c3da7a9662566a5a27c5ad90ac9cbe794e7f68d) Adjust report views to resolve same problem - [`44cf93a`](https://github.com/netbox-community/netbox/commit/44cf93a7f808f4e7642ff540dadc961bb89fd73c) Fixed PEP8 error - [`1c2b460`](https://github.com/netbox-community/netbox/commit/1c2b460a9cf3de3ab254377e0720b23617e8ebf2) Update netbox/templates/extras/script/base.html - [`a2086e7`](https://github.com/netbox-community/netbox/commit/a2086e799587ebf95262b16bddcac76f401d2d88) Move function to method on PythonModuleMixin - [`7560f4a`](https://github.com/netbox-community/netbox/commit/7560f4a013ea705fb148804e5d4fb0d05f0fd005) Update netbox/extras/views.py - [`8918b11`](https://github.com/netbox-community/netbox/commit/8918b111d3fa56917704099a752abdc49e1f24a5) Update netbox/extras/views.py - [`33075a0`](https://github.com/netbox-community/netbox/commit/33075a09a131512b78d05b62e19f994d46476406) Update netbox/extras/views.py - [`206db57`](https://github.com/netbox-community/netbox/commit/206db577b409ff9a5c9049dfe5c8dd3bfb8cfd2b) Update netbox/extras/views.py - [`6f85dbb`](https://github.com/netbox-community/netbox/commit/6f85dbb62694cdd8c2953955b6b0b506e6fb3f37) Update to mixin and view ### 📊 Changes **4 files changed** (+31 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/models/mixins.py` (+10 -0) 📝 `netbox/extras/views.py` (+19 -25) 📝 `netbox/templates/extras/report/base.html` (+1 -1) 📝 `netbox/templates/extras/script/base.html` (+1 -1) </details> ### 📄 Description ### Fixes: #14572 - Constrains JobView to specific job * Create new method to return relevant jobs * Call method to provide 'jobs' key for rendered context data --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 23:24:32 +01:00
adam closed this issue 2025-12-29 23:24:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#14450
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?